Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally #3103

Closed
srirambv opened this issue Jan 25, 2019 · 2 comments · Fixed by brave/brave-core#1525
Closed

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally #3103

srirambv opened this issue Jan 25, 2019 · 2 comments · Fixed by brave/brave-core#1525
Assignees
@NejcZdovc
Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Rewards Team
Milestone
0.61.x - Release ...

Comments

@srirambv
Copy link
Contributor

Description

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally

Steps to Reproduce

  1. Enable rewards
  2. Disable a-c in brave://rewards
  3. Visit any site and open BR panel , Include in Auto-Contribute is enabled even though a-c is disabled in rewards settings page

Actual result:

BR panel shows Include in Auto-Contribute as enabled when a-c is disabled globally

Expected result:

BR panel should probably hide the Attention and Include in Auto-contribute lines when a-c is disabled.

Reproduces how often:

Easy

Brave version (brave://version info)

All

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?
    Yes

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

cc: @davidtemkin @jenn-rhim @NejcZdovc
Issue reported by community user https://community.brave.com/t/bug-alert-i-turned-off-the-automatic-rewards-but-it-turns-itself-on-for-any-new-website-visited/43082/7
@srirambv srirambv added suggestion design A design change, especially one which needs input from the design team feature/rewards QA/Yes release-notes/exclude labels Jan 25, 2019
@srirambv srirambv added this to the 1.x Backlog milestone Jan 25, 2019
@srirambv srirambv added this to Untriaged Backlog in Rewards via automation Jan 25, 2019
@NejcZdovc
Copy link
Contributor

Agree

@NejcZdovc NejcZdovc added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jan 25, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Jan 25, 2019
@NejcZdovc NejcZdovc added this to Jason in Rewards Team Jan 25, 2019
@NejcZdovc NejcZdovc assigned NejcZdovc and unassigned jasonrsadler Jan 31, 2019
@NejcZdovc NejcZdovc moved this from Jason to Nejc in Rewards Team Jan 31, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 31, 2019
Merged
9 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 31, 2019
@NejcZdovc
Hide AC options in the panel if AC if off
cc8e168 
Resolves brave/brave-browser#3103
@NejcZdovc NejcZdovc mentioned this issue Jan 31, 2019
Merged
18 tasks
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 31, 2019
@NejcZdovc
Hide AC options in the panel if AC if off
265fb22 
Resolves brave/brave-browser#3103
@NejcZdovc NejcZdovc moved this from P3, P4, & P5 Backlog to Pending review in Rewards Jan 31, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 31, 2019
@NejcZdovc
Hide AC options in the panel if AC if off
17b7bc6 
Resolves brave/brave-browser#3103
Rewards automation moved this from Pending review to Completed Jan 31, 2019
Rewards Team automation moved this from Nejc to Closed Jan 31, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 31, 2019
Merged
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Jan 31, 2019
@NejcZdovc NejcZdovc mentioned this issue Jan 31, 2019
Closed
@btlechowski
Copy link
Collaborator

btlechowski commented Feb 25, 2019 •
edited by LaurenWags

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1525

a-c off
image

a-c on
image

Verification passed on

Brave 0.61.39 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux Mint

Verified passed with

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

@kjozwiak kjozwiak mentioned this issue Mar 1, 2019
Closed
@kjozwiak kjozwiak mentioned this issue Mar 12, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@NejcZdovc NejcZdovc

Labels
design A design change, especially one which needs input from the design team feature/rewards priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
No open projects
Rewards Team
Closed
Milestone
0.61.x - Release (Release Channel)
Development

Successfully merging a pull request may close this issue.

Hide AC options in the panel if AC if off brave/brave-core
7 participants
@rebron @NejcZdovc @srirambv @jasonrsadler @LaurenWags @btlechowski @GeetaSarvadnya