Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Two banners at the same time #3125

Closed
NejcZdovc opened this issue Jan 28, 2019 · 1 comment · Fixed by brave/brave-core#1490
Closed

Two banners at the same time #3125

NejcZdovc opened this issue Jan 28, 2019 · 1 comment · Fixed by brave/brave-core#1490

Comments

@NejcZdovc
Copy link
Contributor

Description

Steps to Reproduce

  1. enable rewards
  2. go to a site and open tip banner
  3. open new window, load a site and open tip banner
  4. banner from step 2 will be updated with banner from site 3

Actual result:

image

Same happens if you open it in one tab and then in another and then come back to the initial tab, banner will be wrong

Expected result:

banner should be per tab

Reproduces how often:

Brave version (brave://version info)

Reproducible on current release:

  • Does it reproduce on brave-browser dev/beta builds?

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
  • Is the issue reproducible on the latest version of Chrome?

Additional Information

cc @petemill

@NejcZdovc NejcZdovc added this to the 1.x Backlog milestone Jan 28, 2019
@NejcZdovc NejcZdovc added this to Untriaged Backlog in Rewards via automation Jan 28, 2019
@NejcZdovc NejcZdovc added QA/Yes priority/P3 The next thing for us to work on. It'll ride the trains. labels Jan 28, 2019
@NejcZdovc NejcZdovc moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Rewards Jan 29, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Jan 29, 2019
@NejcZdovc NejcZdovc moved this from P3, P4, & P5 Backlog to Pending review in Rewards Jan 29, 2019
@NejcZdovc NejcZdovc self-assigned this Jan 29, 2019
@NejcZdovc NejcZdovc added this to Nejc in Rewards Team Jan 30, 2019
Rewards automation moved this from Pending review to Completed Feb 1, 2019
Rewards Team automation moved this from Nejc to Closed Feb 1, 2019
@NejcZdovc NejcZdovc modified the milestones: 1.x Backlog, 0.61.x - Dev Feb 1, 2019
@btlechowski
Copy link

btlechowski commented Feb 25, 2019

Verification passed on

Brave 0.61.37 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Windows 7 Service Pack 1 Build 7601.24312

Used test plan from brave/brave-core#1490

image

Verification passed on

Brave 0.61.40 Chromium: 73.0.3683.39 (Official Build) beta (64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Linux mint

Verification PASSED on macOS 10.14.3 x64 using the following build:

Brave 0.61.45 Chromium: 73.0.3683.39 (Official Build) beta(64-bit)
Revision cc53b0e12fcaf42e4bab8d6c23bd4fb7aae99f6c-refs/branch-heads/3683@{#413}
OS Mac OS X

screen shot 2019-03-05 at 1 32 13 am

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
No open projects
Development

Successfully merging a pull request may close this issue.

4 participants