Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Hide local network assets when local networks are disabled (Crash) #31357

Closed
Pavneet-Sing opened this issue Jun 28, 2023 · 2 comments · Fixed by brave/brave-core#19113
Closed

Hide local network assets when local networks are disabled (Crash) #31357

Pavneet-Sing opened this issue Jun 28, 2023 · 2 comments · Fixed by brave/brave-core#19113
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.52.x - Release #7

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jun 28, 2023 •
edited

Description

Hide local network assets when local networks are disabled, could cause a crash like #31303
Local networks are disabled in all GPS versions.

Actual result

network-crash.webm

Expected result

Local network assets should be hidden when local networks are disabled.

Issue reproduces how often

easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Y
  • Can you reproduce this issue with the current Play Store Beta version? Y
  • Can you reproduce this issue with the current Play Store Nightly version? Y
@Pavneet-Sing Pavneet-Sing added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jun 28, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 28, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Jun 30, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.55.x - Nightly milestone Jun 30, 2023
This was referenced Jun 30, 2023
Merged
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Jul 5, 2023

The above requires 1.52.130 or higher for 1.52.x verification 👍

@Pavneet-Sing Pavneet-Sing mentioned this issue Jul 5, 2023
Merged
7 tasks
@srirambv
Copy link
Contributor

srirambv commented Jul 6, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.52.130 x64 build

  • Verified steps from brave/brave-core#19113
  • Verified localhost network is not listed in the GPS build for any network
31357.mp4

@kjozwiak kjozwiak mentioned this issue Jul 7, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.52.x - Release #7
Development

Successfully merging a pull request may close this issue.

Remove local network assets in GPS variants brave/brave-core
4 participants
@kjozwiak @Pavneet-Sing @srirambv @brave-builds