Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove local network assets in GPS variants (uplift to 1.54.x) #19114

Merged
merged 2 commits into from
Jul 5, 2023
Merged

Remove local network assets in GPS variants (uplift to 1.54.x) #19114

merged 2 commits into from
Jul 5, 2023

Conversation

Pavneet-Sing
Copy link
Contributor

@Pavneet-Sing Pavneet-Sing commented Jun 30, 2023 •
edited

Uplift of #19113
Resolves brave/brave-browser#31357

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@Pavneet-Sing Pavneet-Sing added CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-ios Do not run CI builds for iOS CI/skip-windows-x86 CI/skip-windows-x64 Do not run CI builds for Windows x64 unused-CI/skip-linux-x64 Do not run CI builds for Linux x64 labels Jun 30, 2023
@Pavneet-Sing Pavneet-Sing self-assigned this Jun 30, 2023
@Pavneet-Sing Pavneet-Sing requested a review from a team as a code owner June 30, 2023 13:29
@Pavneet-Sing Pavneet-Sing changed the title - Remove local network assets in GPS variants Remove local network assets in GPS variants (uplift to 1.54.x) Jun 30, 2023
@Pavneet-Sing Pavneet-Sing added this to the 1.54.x - Beta milestone Jun 30, 2023
kjozwiak
kjozwiak approved these changes Jul 5, 2023
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.54.x approved 👍 QA has verified the PR on Nightly as per #19113 (comment).

@kjozwiak kjozwiak merged commit a9775fd into 1.54.x Jul 5, 2023
10 checks passed
@kjozwiak kjozwiak deleted the pr19113_stip-local-networks-in-gps-variants_1.54.x branch July 5, 2023 04:01
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@Pavneet-Sing Pavneet-Sing

Labels
CI/skip-ios Do not run CI builds for iOS CI/skip-macos-x64 Do not run CI builds for macOS x64 CI/skip-windows-x64 Do not run CI builds for Windows x64 feature/web3/wallet unused-CI/skip-linux-x64 Do not run CI builds for Linux x64
Projects
None yet
Milestone
1.57.x - Release
2 participants
@Pavneet-Sing @kjozwiak