Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Peertube playback (torrent issue) #3164

Closed
ChameleonScales opened this issue Jan 30, 2019 · 9 comments · Fixed by brave/brave-core#3035
Closed

Peertube playback (torrent issue) #3164

ChameleonScales opened this issue Jan 30, 2019 · 9 comments · Fixed by brave/brave-core#3035
Assignees
@feross
Labels
bug feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Milestone
0.69.x - Release

Comments

@ChameleonScales
Copy link

ChameleonScales commented Jan 30, 2019 •
edited
Loading

Description

When attempting to watch a video on any Peertube instance, I get this message:
"Sorry, but this video is not available because the remote instance is not responding.
Please try again later."

Example:

https://video.blender.org/videos/watch/f507dfdc-e73e-45a4-9778-d758cbe1ce96

Brave version:

Brave: 0.58.21 Chromium: 71.0.3578.98 (Official Build) (64-bit)
Revision: 15234034d19b85dcd9a03b164ae89d04145d8368-refs/branch-heads/3578@{#897}
OS: Linux

Reproducible on current release:

Yes:
Brave: 0.61.2 Chromium: 72.0.3626.71 (Official Build) dev(64-bit)
Revision: f52ccad2a6a3c65fc9e0c591a517ceab1198dac0-refs/branch-heads/3626@{#763}
OS: Linux

Website problems only:

  • Does the issue resolve itself when disabling Brave Shields?
    No
  • Is the issue reproducible on the latest version of Chrome?
    No

Additional Information

Related issue: brave/browser-laptop#10672
@rebron rebron added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label Feb 1, 2019
@rebron rebron modified the milestone: 1.x Backlog Feb 1, 2019
@blakeearth
Copy link

This is currently an issue on Version 0.63.9 Chromium: 73.0.3683.75 (Official Build) dev (64-bit). I love Brave's philosophy, and I hope it will be increasingly useful in escaping centralized and privacy-unfriendly services like YouTube (in addition to making sites like YouTube safer and more private to use). I think this is an important issue for that reason, as PeerTube has different (and significantly less centralized) privacy concerns than YouTube and other popular streaming websites.

@bsclifton bsclifton added the webcompat/not-shields-related Sites are breaking because of something other than Shields. label Mar 19, 2019
@blakeearth
Copy link

For now, Brave users should be able to disable the WebTorrent extension as a workaround, and PeerTube should work as normal. Go to brave://settings, search for WebTorrent, and disable it. This is a problem with Brave's WebTorrent extension.

@pookito
Copy link

pookito commented Jun 10, 2019

For now, Brave users should be able to disable the WebTorrent extension as a workaround, and PeerTube should work as normal. Go to brave://settings, search for WebTorrent, and disable it. This is a problem with Brave's WebTorrent extension.

Thanks for the advise. I was having the same problem as you stated and solved it. I just thought about dropping a line of thanks. 👍

@feross feross added this to To do in WebTorrent Jul 23, 2019
@feross
Copy link

feross commented Jul 23, 2019

Related: #5361

@feross feross self-assigned this Jul 24, 2019
@feross feross moved this from To do to In progress in WebTorrent Jul 24, 2019
@feross feross added QA/Test-Plan-Specified QA/Yes feature/webtorrent Label for webtorrent related issues labels Jul 26, 2019
feross added a commit to brave/brave-core that referenced this issue Jul 26, 2019
@feross
WebTorrent: intercept only top-level frame requests for .torrent files
9240cd6 
If a web page embeds the WebTorrent client-side JS library and attempts to
load a .torrent file using an XHR request or fetch, Brave will intercept the
.torrent file load and replace it with the chrome-extension HTML, breaking the
site. This is true not just for the WebTorrent JS library but for any request
to fetch a .torrent file.

Fixes: brave/brave-browser#5361
Fixes: brave/brave-browser#3164
Fixes: brave/brave-browser#1436
@feross feross mentioned this issue Jul 26, 2019
Merged
32 tasks
feross added a commit to brave/brave-core that referenced this issue Jul 26, 2019
@feross
WebTorrent: intercept only top-level frame requests for .torrent files
03868fe 
If a web page embeds the WebTorrent client-side JS library and attempts to
load a .torrent file using an XHR request or fetch, Brave will intercept the
.torrent file load and replace it with the chrome-extension HTML, breaking the
site. This is true not just for the WebTorrent JS library but for any request
to fetch a .torrent file.

Fixes: brave/brave-browser#5361
Fixes: brave/brave-browser#3164
Fixes: brave/brave-browser#1436
@feross feross moved this from In progress to PR sent in WebTorrent Jul 26, 2019
@feross
Copy link

feross commented Jul 26, 2019

Confirmed that this is the same issue as #5361 and it is fixed by this PR: brave/brave-core#3035

@feross feross added the bug label Jul 26, 2019
WebTorrent automation moved this from PR sent to Done Jul 27, 2019
@kjozwiak kjozwiak added this to the 0.70.x - Nightly milestone Jul 27, 2019
@kjozwiak
Copy link
Member

kjozwiak commented Sep 18, 2019 •
edited by GeetaSarvadnya
Loading

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.126 Chromium: 77.0.3865.65 (Official Build) (64-bit)
Revision 87a331a3169cab563505fb44011058b904011ba1-refs/branch-heads/3865@{#726}
OS macOS Version 10.14.6 (Build 18G95)

Verification passed on

Brave 0.69.127 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Ubuntu 18.04 LTS

Verification passed on

Brave 0.69.128 Chromium: 77.0.3865.75 (Official Build) (64-bit)
Revision 201e747d032611c5f2785cae06e894cf85be7f8a-refs/branch-heads/3865@{#776}
OS Windows 10 OS Version 1803 (Build 17134.1006)

@kjozwiak
Copy link
Member

@feross please let me know if the above test cases are sufficient enough for verification ☝️

@feross
Copy link

feross commented Sep 18, 2019

@kjozwiak That should be sufficient validation!

@pookito
Copy link

pookito commented Oct 18, 2019 via email

@rebron rebron removed this from Done in WebTorrent Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feross feross

Labels
bug feature/webtorrent Label for webtorrent related issues priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-Plan-Specified QA/Yes release-notes/exclude webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

WebTorrent: intercept only top-level frame requests for .torrent files brave/brave-core
10 participants
@feross @kjozwiak @pookito @bsclifton @rebron @ChameleonScales @blakeearth @LaurenWags @btlechowski @GeetaSarvadnya