Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Load brave://settings page in a new tab when clicking the settings button from the sidebar #31663

Closed
simonhong opened this issue Jul 17, 2023 · 3 comments · Fixed by brave/brave-core#19302

Comments

@simonhong
Copy link
Member

Description

Load sidebar settings page in a new tab when clicks sidebar settings button

Steps to Reproduce

  1. Click Sidebar settings button

Actual result:

Sidebar settings page is loaded in current tab

Expected result:

Sidebar settings page is loaded in new tab

If current tab is new tab, settings page is loaded in current tab.
If browser windows already has sidebar settings tab, it's activated instead of creating new tab

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@Silvrbckw
Copy link

commit and push

@MadhaviSeelam
Copy link

Verification PASSED using

Brave | 1.58.88 Chromium: 116.0.5845.82 (Official Build) beta (64-bit)
-- | --
Revision | acf16e35d5897fd4bf9b1b5a93b56aff2ed64bba
OS | Windows 11 Version 22H2 (Build 22621.2134)

Reproduced the issue in 1.56.20

2023-08-14_15h29_41.mp4

Steps:

  • Installed 1.58.88
  • launched Brave
  • clicked Settings button in the Sidebar

Confirmed brave://settings/?search=Sidebar page loaded in a new tab

2023-08-14_15h39_07.mp4

@pfSecure
Copy link

Not fixed in latest version, released today. When I click on the "show settings" on the sidebar (on the bottom) it open on current tab. It not open in new tab.

@rebron rebron changed the title Load sidebar settings page in a new tab when clicks sidebar settings button Load brave://settings page in a new tab when clicking the settings button from the sidebar Aug 31, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants