Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

NFTs stays visible after marked as invisible in edit visible #31915

Closed
Pavneet-Sing opened this issue Jul 27, 2023 · 2 comments · Fixed by brave/brave-core#20361
Closed

NFTs stays visible after marked as invisible in edit visible #31915

Pavneet-Sing opened this issue Jul 27, 2023 · 2 comments · Fixed by brave/brave-core#20361
Assignees
@simoarpe
Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Jul 27, 2023 •
edited

Steps to reproduce

  1. Open NFT tab
  2. Mark some NFTs as invisible via edit visible and save
  3. Open edit visible again

Actual result

nft-visibility.webm

Expected result

Invisible/Hidden NFTs should not be shown as checked/visible
@Pavneet-Sing Pavneet-Sing added QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Jul 27, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Jul 28, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Sep 8, 2023
Closed
@simoarpe simoarpe self-assigned this Sep 22, 2023
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. feature/web3/wallet/nft and removed priority/P4 Planned work. We expect to get to it "soon". labels Sep 25, 2023
@simoarpe simoarpe mentioned this issue Oct 3, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.61.x - Nightly milestone Oct 5, 2023
This was referenced Oct 6, 2023
Merged
Merged
@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2023

The above requires 1.59.113 or higher for 1.59.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Oct 9, 2023

Verified as part of #33255 (comment)

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simoarpe simoarpe

Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Fix NFT visibility in BottomSheet fragment brave/brave-core
6 participants
@kjozwiak @simoarpe @Pavneet-Sing @HEagle18 @srirambv @brave-builds