Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Hide/unhide NFT doesn't work as expected #33255

Closed
srirambv opened this issue Sep 26, 2023 · 2 comments · Fixed by brave/brave-core#20361
Closed

Hide/unhide NFT doesn't work as expected #33255

srirambv opened this issue Sep 26, 2023 · 2 comments · Fixed by brave/brave-core#20361
Assignees
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Hide/unhide NFT doesn't work as expected

Steps to reproduce

  1. Restore wallet that has a few NFTs
  2. Enable NFT view to list the NFTs
  3. Add a new NFT that you don't own and make sure it lists in visible NFTs
  4. Go to Edit NFT and uncheck the newly added NFT and an existing one
  5. Refreshes and hides the NFTs
  6. Go to Hidden tab of NFT and open edit visible NFT
  7. All NFTs are selected
  8. Uncheck the added NFT from step 3
  9. NFT tab reloads but doesn't unhide the NFT

Actual result

Unhide.NFT.mp4

Expected result

Hidden NFTs should not be selected when edit NFT is hidden tab. Also should be able to unhide NFTs

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone
  • Android version: 13

Brave version

1.59.93 x64 Beta build

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe @Pavneet-Sing

@kjozwiak
Copy link
Member

kjozwiak commented Oct 6, 2023

The above requires 1.59.113 or higher for 1.59.x verification 👍

@srirambv
Copy link
Contributor Author

srirambv commented Oct 9, 2023

Verification passed on Oppo Reno 5 with Android 13 running 1.59.115 x64 build

  • Verified steps from issue description and brave/brave-core#20361
  • Verified unchecking NFTs moves them into hidden tab
  • Verified checking NFTs moves them back into collected tab
20361.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA Pass - Android ARM QA/Yes release-notes/exclude
Projects
Archived in project
Development

Successfully merging a pull request may close this issue.

5 participants