Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Autoredirect IPFS resources promo infobar #32010

Closed
cypt4 opened this issue Aug 1, 2023 · 5 comments · Fixed by brave/brave-core#19588
Closed

Autoredirect IPFS resources promo infobar #32010

cypt4 opened this issue Aug 1, 2023 · 5 comments · Fixed by brave/brave-core#19588
Assignees
@cypt4
Labels
feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@cypt4
Copy link
Collaborator

cypt4 commented Aug 1, 2023

When user visits some IPFS-related resource which is available for redirect when "Automatically redirect requests for IPFS network resources to the configured gateway." setting, promo infobar should be shown, so user could enable this setting from the tab.
@cypt4 cypt4 added OS/Android Fixes related to Android browser functionality OS/Desktop feature/web3/ipfs labels Aug 1, 2023
@cypt4 cypt4 self-assigned this Aug 2, 2023
@HEagle18 HEagle18 added the priority/P4 Planned work. We expect to get to it "soon". label Aug 4, 2023
cypt4 added a commit to brave/brave-core that referenced this issue Aug 7, 2023
@cypt4
Introduce IPFS promo infobar
33f4fde 
Resolves brave/brave-browser#32010
@cypt4 cypt4 mentioned this issue Aug 7, 2023
Merged
25 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Aug 7, 2023
@cypt4
Introduce IPFS promo infobar
b333006 
Resolves brave/brave-browser#32010
cypt4 added a commit to brave/brave-core that referenced this issue Aug 8, 2023
@cypt4
Introduce IPFS promo infobar
8fe3892 
Resolves brave/brave-browser#32010
cypt4 added a commit to brave/brave-core that referenced this issue Aug 8, 2023
@cypt4
Introduce IPFS promo infobar
ae618e8 
Resolves brave/brave-browser#32010
cypt4 added a commit to brave/brave-core that referenced this issue Aug 8, 2023
@cypt4
Introduce IPFS promo infobar
d3b30ea 
Resolves brave/brave-browser#32010
cypt4 added a commit to brave/brave-core that referenced this issue Aug 16, 2023
@cypt4
Introduce IPFS promo infobar
99cb287 
Resolves brave/brave-browser#32010
cypt4 added a commit to brave/brave-core that referenced this issue Aug 18, 2023
@cypt4
Introduce IPFS promo infobar (#19588)
32109b6 
* Introduce IPFS promo infobar
Resolves brave/brave-browser#32010
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 18, 2023
@brave-builds brave-builds mentioned this issue Aug 18, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

The above requires 1.58.99 or higher for 1.58.x verification 👍

@kjozwiak
Copy link
Member

@srirambv @cypt4 thoughts on this being QA/Test-All-Platforms? Or should one device/platform for Android & Desktop be enough?

@srirambv
Copy link
Contributor

Should be Test all platforms

@srirambv
Copy link
Contributor

srirambv commented Sep 1, 2023

Verification passed on

Brave 1.58.109 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision a4ad1fcdb550daf076384dbb280ae944274b3d35
OS Windows 11 Version 22H2 (Build 22621.2215)
  • Verified steps from brave/brave-core#19588
  • Verified new promo info bar is shown for links that can be loaded via IPFS
  • Verified selecting Always doesn't show for other links opened after it
  • Verified selecting Only once continues to show the info bar every time the link is visited
  • Verified selecting No Thanks doesn't show the info bar any more
  • Verified selecting Always enables Automatically redirect requests for IPFS network resources to the configured gateway. setting
32010.mp4

Verification passed on

Brave 1.58.109 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision a4ad1fcdb550daf076384dbb280ae944274b3d35
OS Linux
  • Verified steps from brave/brave-core#19588
  • Verified new promo info bar is shown for links that can be loaded via IPFS
  • Verified selecting Always doesn't show for other links opened after it
  • Verified selecting Only once continues to show the info bar every time the link is visited
  • Verified selecting No Thanks doesn't show the info bar any more
  • Verified selecting Always enables Automatically redirect requests for IPFS network resources to the configured gateway. setting
32010.mp4

Verification passed on

Brave 1.58.109 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision a4ad1fcdb550daf076384dbb280ae944274b3d35
OS macOS Version 13.4.1 (c) (Build 22F770820d)
  • Verified steps from brave/brave-core#19588
  • Verified new promo info bar is shown for links that can be loaded via IPFS
  • Verified selecting Always doesn't show for other links opened after it
  • Verified selecting Only once continues to show the info bar every time the link is visited
  • Verified selecting No Thanks doesn't show the info bar any more
  • Verified selecting Always enables Automatically redirect requests for IPFS network resources to the configured gateway. setting
32010.mp4

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
@srirambv
Copy link
Contributor

srirambv commented Sep 14, 2023 •
edited

This is desktop only for now. Will need separate Android work when needed.

@srirambv srirambv removed the OS/Android Fixes related to Android browser functionality label Sep 14, 2023
@srirambv srirambv mentioned this issue Sep 14, 2023
Open
@cypt4 cypt4 mentioned this issue Sep 19, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
feature/web3/ipfs OS/Desktop priority/P4 Planned work. We expect to get to it "soon". QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

Introduce IPFS promo infobar brave/brave-core
5 participants
@kjozwiak @HEagle18 @srirambv @brave-builds @cypt4