Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update Stripe text description #32226

Closed
HEagle18 opened this issue Aug 14, 2023 · 2 comments · Fixed by brave/brave-core#19866
Closed

Update Stripe text description #32226

HEagle18 opened this issue Aug 14, 2023 · 2 comments · Fixed by brave/brave-core#19866
Assignees
@Douglashdaniel
Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.58.x - Release

Comments

@HEagle18
Copy link

HEagle18 commented Aug 14, 2023 •
edited
Loading

Description

Stripe would like their text and logos updated on Brave Wallet..

logo: (Link logo (favicon Teal))
name: Link by Stripe
description: Instantly buy crypto with credit card, debit card, or bank account at crypto.link.com
button: Buy with Link

Their brand guidelines are attached
[Public] Onramp brand guidelines.pdf

There is also a slack with stripe, if you need to be added. (convo from slack channel https://stripe.slack.com/archives/C0525LVHJ65/p1692114249199379?thread_ts=1691186913.138699&cid=C0525LVHJ65)

Steps to Reproduce

  1. go to brave wallet
  2. go to buys and pick an asset and an amount
  3. see list of third parties and text associated

Actual result:

Screens that need updatingt
Screenshot 2023-08-14 at 17 03 25
Screenshot 2023-08-14 at 17 03 51

Expected result:

Reproduces how often:

Desktop Brave version:

Android Device details:

  • Install type (ARM, x86):
  • Device type (Phone, Tablet, Phablet):
  • Android version:

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@HEagle18 HEagle18 added needs-text-change This change requires some careful wording. OS/Desktop front-end-change This task is a front end task and doesn't need any C++ changes labels Aug 14, 2023
@Douglashdaniel Douglashdaniel self-assigned this Aug 16, 2023
@StephenHeaps StephenHeaps mentioned this issue Aug 17, 2023
Open
@Douglashdaniel Douglashdaniel mentioned this issue Aug 24, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Aug 29, 2023
@Douglashdaniel Douglashdaniel mentioned this issue Aug 29, 2023
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Sep 3, 2023

The above requires 1.58.113 or higher for 1.58.x verification 👍

@srirambv
Copy link
Contributor

srirambv commented Sep 4, 2023 •
edited
Loading

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Linux

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build)) beta (64-bit)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS Windows 11 Version 22H2 (Build 22621.2215)

Verification passed on

Brave 1.58.114 Chromium: 116.0.5845.163 (Official Build) beta (arm64)
Revision 21631edab5a70964c2f5817bfa4d06c32b4ab314
OS macOS Version 13.4.1 (c) (Build 22F770820d)

@LaurenWags LaurenWags mentioned this issue Sep 13, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Douglashdaniel Douglashdaniel

Labels
feature/web3/wallet Integrating Ethereum+ wallet support front-end-change This task is a front end task and doesn't need any C++ changes needs-text-change This change requires some careful wording. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.58.x - Release
Development

Successfully merging a pull request may close this issue.

fix(wallet): Update Stripe Onramp Description brave/brave-core
5 participants
@kjozwiak @HEagle18 @srirambv @Douglashdaniel @brave-builds