Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow Multiple Selection for Network Filters #32644

Closed
4 tasks done
Tracked by #32438
Pavneet-Sing opened this issue Aug 31, 2023 · 1 comment · Fixed by brave/brave-core#19959
Closed
4 tasks done
Tracked by #32438

Allow Multiple Selection for Network Filters #32644

Pavneet-Sing opened this issue Aug 31, 2023 · 1 comment · Fixed by brave/brave-core#19959
Assignees
@Pavneet-Sing
Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Milestone
1.59.x - Release

Comments

@Pavneet-Sing
Copy link

Pavneet-Sing commented Aug 31, 2023 •
edited
Loading

Allow selecting multiple networks in the Network selection screen for Portfolio tab and NFT tab along with:

  • Select and deselect all option
  • Close button
  • Show empty state with no assets (add description later once filter dialog is ready)
  • Update edit visible dialog to use all networks by default and remove passed single network
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 31, 2023
Open
@Pavneet-Sing Pavneet-Sing self-assigned this Aug 31, 2023
@Pavneet-Sing Pavneet-Sing added priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality feature/web3/wallet/nft labels Aug 31, 2023
@Pavneet-Sing Pavneet-Sing mentioned this issue Aug 31, 2023
Merged
25 tasks
@brave-builds brave-builds added this to the 1.59.x - Nightly milestone Sep 1, 2023
@srirambv
Copy link
Contributor

Verification passed on the following devices running 1.59.93 x64 Beta build

  • Verified steps from brave/brave-core#19959
  • Verified able to filter networks on both portfolio and NFT
  • Verified when all networks are disabled empty state message is shown
  • Verified selecting and closing the button updates the selections of networks
  • Encountered #33206, #33208, #33210
Oppo Reno 5 (Android 13) Lenovo Tab (Android 12)
32644-ARM.mp4
32644-Tab.mp4

@kjozwiak kjozwiak mentioned this issue Nov 15, 2023
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@Pavneet-Sing Pavneet-Sing

Labels
feature/web3/wallet/nft feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android ARM QA Pass - Android Tab QA/Yes release-notes/include
Projects
Web3
Archived in project
Milestone
1.59.x - Release
Development

Successfully merging a pull request may close this issue.

Allow multiple network selection brave/brave-core
3 participants
@Pavneet-Sing @srirambv @brave-builds