Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assets/NFT tabs looks really small on a large screen #33210

Closed
srirambv opened this issue Sep 22, 2023 · 3 comments
Closed

Assets/NFT tabs looks really small on a large screen #33210

srirambv opened this issue Sep 22, 2023 · 3 comments
Assignees
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude

Comments

@srirambv
Copy link
Contributor

Description

Assets/NFT tabs looks really small on a large screen

Steps to reproduce

  1. Open Wallet in a tab
  2. Assets and NFT tabs highlights are really small

Actual result

Asset NFT

Expected result

Better design for tablet view

Issue reproduces how often

Easy

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? NA
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Not checked

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Tablet
  • Android version:12

Brave version

1.59.93

Website problems only

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards?NA
  • Is the issue reproducible on the latest version of Chrome? NA

Additional information

cc: @simoarpe @Pavneet-Sing

@srirambv srirambv added design A design change, especially one which needs input from the design team QA/Yes release-notes/exclude feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality labels Sep 22, 2023
@simoarpe simoarpe self-assigned this Sep 22, 2023
@simoarpe
Copy link

🙌 Nice catch @srirambv! It should be a pretty quick fix, I'm assigning this to me.
What's the device you used to observe the issue? Thanks

@srirambv
Copy link
Contributor Author

What's the device you used to observe the issue?

Lenovo Tab with Android 12.

@simoarpe
Copy link

Issue not relevant anymore as we switched to WebUI where Assets and NFTs tabs have responsive design, and they are shown correctly on tablets. I'm closing this.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
design A design change, especially one which needs input from the design team feature/web3/wallet Integrating Ethereum+ wallet support OS/Android Fixes related to Android browser functionality QA/Yes release-notes/exclude
Projects
Archived in project
Development

No branches or pull requests

2 participants