Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update "Logged out" notice text (October 2023) #33583

Closed
Miyayes opened this issue Oct 11, 2023 · 3 comments · Fixed by brave/brave-core#20815
Closed

Update "Logged out" notice text (October 2023) #33583

Miyayes opened this issue Oct 11, 2023 · 3 comments · Fixed by brave/brave-core#20815
Assignees
@emerick
Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.62.x - Release

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Oct 11, 2023 •
edited
Loading

This happens from time to time to keep your {{custodianName}} account secure. While logged out, you will continue to receive payouts, but won't be able to see your balance or send contributions from your {{custodianName}} account.

[Log in again]

image
@Miyayes Miyayes added QA/Yes release-notes/include priority/P3 The next thing for us to work on. It'll ride the trains. labels Oct 17, 2023
@emerick emerick mentioned this issue Nov 2, 2023
Merged
25 tasks
@emerick emerick added this to the 1.62.x - Nightly milestone Nov 2, 2023
@LaurenWags
Copy link
Member

LaurenWags commented Dec 1, 2023 •
edited
Loading

Verified with

Brave | 1.62.93 Chromium: 120.0.6099.35 (Official Build) beta (x86_64)
-- | --
Revision | 2032da61e85b8d826ab474ee36fee9a9cee09907
OS | macOS Version 13.6.1 (Build 22G313)

Encountered #34670 while testing.

Uphold - PASSED

Compared text between 1.61.x and 1.62.x.
Confirmed text was as per the description.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

1.61.x 1.62.x
1 2
Gemini - FAILED, follow up issue logged

Compared text between 1.61.x and 1.62.x.
Confirmed text was as per the description. - FAILED, lists "Uphold" as provider when the provider is actually Gemini. Logged #34670 as follow up issue.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

1.61.x 1.62.x
1 2
ZebPay - FAILED, follow up issue logged

Compared text between 1.61.x and 1.62.x.
Confirmed text was as per the description. - FAILED, lists "Uphold" as provider when the provider is actually Gemini. Logged #34670 as follow up issue.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

1.61.x 1.62.x
1 61 zeb 1 62 zeb 
Brave | 1.62.99 Chromium: 120.0.6099.62 (Official Build) beta (x86_64)
-- | --
Revision | 0f3e892de210168e788b3418961f94c4d0c5942a
OS | macOS Version 13.6.1 (Build 22G313)
bitFlyer - FAILED, follow up issue logged

Confirmed text was as per the description. - FAILED, lists "Uphold" as provider when the provider is actually Gemini. Logged #34670 as follow up issue.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

Screenshot 2023-12-07 at 1 51 56 PM

@LaurenWags LaurenWags added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Dec 1, 2023
@LaurenWags LaurenWags mentioned this issue Dec 1, 2023
Closed
@LaurenWags LaurenWags added QA Pass-macOS and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Dec 7, 2023
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 14, 2023 •
edited
Loading

Verification PASSED on

Brave | 1.62.107 Chromium: 120.0.6099.115 (Official Build) beta (64-bit)
-- | --
Revision | 67a3b21572338a0660bb25a5855da0f1e9372a39
OS | Windows 10 Version 22H2 (Build 19045.3803)
Uphold - PASSED

Compared text between 1.61.x and 1.62.x.
Confirmed text was as per the description.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

1.61.x 1.62.x
image image
Gemini - PASSED

Compared text between 1.61.x and 1.62.x.
Confirmed text was as per the description.
Confirmed "Log in again" directed to the custodian site for authorization as expected.

1.61.x 1.62.x
image image

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Dec 20, 2023 •
edited
Loading

Verified the issue on Samsung galaxy version 12 running Bravemonoarm64.apk_1.62.114 and ensured that the logged state is still showing up the old message as expected
Screenshot_20231220_190154

@LaurenWags LaurenWags mentioned this issue Jan 24, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@emerick emerick

Labels
feature/rewards OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA Pass-Win64 QA/Yes release-notes/include
Projects
Brave Rewards
Status: Done
Milestone
1.62.x - Release
Development

Successfully merging a pull request may close this issue.

Update Rewards logged out notification text brave/brave-core
4 participants
@emerick @Miyayes @LaurenWags @GeetaSarvadnya