Crash on new profile logging into `account.brave.com` #35395

bsclifton · 2024-01-18T04:58:51Z

Description

@pavelbrm reported in Slack. He has a Mac with M2 Pro processor running macOS Sonoma.

Crash seems to be related to VPN service when getting the keyed service for this browser instance. Private window is fine because SKU SDK and VPN service are not created for private profile.

For the code in Brave, the last call is here:
https://github.com/brave/brave-core/blob/b4278ee85661ba2fa7ab7c43ff0c5b08b9f0917d/browser/brave_vpn/brave_vpn_service_factory.cc#L114-L115

That calls into Chromium code here:
https://source.chromium.org/chromium/chromium/src/+/main:components/keyed_service/content/browser_context_keyed_service_factory.cc;l=54-57;drc=12be03159fe22cd4ef291e9561762531c2589539

Seems last recorded call in stack is here:
https://source.chromium.org/chromium/chromium/src/+/main:components/keyed_service/core/keyed_service_factory.cc;l=69;drc=8a6d4b6a266bd766e44387a83b09df5a03eea32f
Error is EXC_BAD_ACCESS / KERN_INVALID_ADDRESS

Steps to Reproduce

Have mac with M2 Pro processor and macOS Sonoma
Fresh profile - use Brave version 1.61.114 or 1.61.116 (others may crash too)
Visit https://account.brave.com
Put an email, hit enter (email and environment not related; repros on any email, in staging and prod)
Copy the link from your email in the browser; paste into URL bar from step 3 and hit enter
Browser crashes

Actual result:

Crashes. Here are a few crash IDs

29280e00-46fb-540b-0000-000000000000
20280e00-46fb-540b-0000-000000000000
26280e00-46fb-540b-0000-000000000000
25280e00-46fb-540b-0000-000000000000

And here is one loaded in backtrace (loadable by Brave employees)
https://brave.sp.backtrace.io/p/brave/debug?filters=JTVCJTVCJTIyX3J4aWQlMjIlMkMlMjJlcXVhbCUyMiUyQyUyMjI5MjgwZTAwLTQ2ZmItNTQwYi0wMDAwLTAwMDAwMDAwMDAwMCUyMiU1RCU1RA%3D%3D&fingerprint=a7674ea25794ca9032868af27f09c2828ea69ccc6bd6da434beb126e1c48c905&debug=(%2265f4bdd%22,0,0)

[ 00 ] KeyedServiceFactory::GetServiceForContext(void*, bool) ( keyed_service_factory.cc:69 )
[ 01 ] BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) ( browser_context_keyed_service_factory.cc:57 )
[ 02 ] brave_vpn::BraveVpnServiceFactory::BindForContext(content::BrowserContext*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_vpn_service_factory.cc:115 )
[ 03 ] brave_vpn::BraveVpnServiceFactory::BindForContext(content::BrowserContext*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_vpn_service_factory.cc:115 )
[ 04 ] (anonymous namespace)::MaybeBindBraveVpnImpl(content::RenderFrameHost*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_content_browser_client.cc:455 )
[ 05 ] base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>)>::Run(content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>) const & ( callback.h:337 )
[ 06 ] void mojo::internal::BinderContextTraits<content::RenderFrameHost*>::BindGenericReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>) ( binder_map_internal.h:40 )
[ 07 ] void base::internal::FunctorTraits<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), void>::Invoke<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:631 )
[ 08 ] void base::internal::InvokeHelper<false, void, 0ul>::MakeItSo<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:868 )
[ 09 ] void base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>>, void (content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>)>::RunImpl<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, 0ul>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, std::__Cr::integer_sequence<unsigned long, 0ul>, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:968 )
[ 10 ] base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>>, void (content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>)>::Run(base::internal::BindStateBase*, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:932 )
[ 11 ] mojo::BinderMapWithContext<content::RenderFrameHost*>::TryBind(content::RenderFrameHost*, mojo::GenericPendingReceiver*) ( callback.h:337 )
[ 12 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::BindInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:88 )
[ 13 ] mojo::BinderMapWithContext<content::RenderFrameHost*>::TryBind(content::RenderFrameHost*, mojo::GenericPendingReceiver*) ( callback.h:337 )
[ 14 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::BindInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:88 )
[ 15 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::GetInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:60 )
[ 16 ] blink::mojom::BrowserInterfaceBrokerStubDispatch::Accept(blink::mojom::BrowserInterfaceBroker*, mojo::Message*) ( browser_interface_broker.mojom.cc:180 )
[ 17 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ( message_dispatcher.cc:48 )
[ 18 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*) ( multiplex_router.cc:710 )
[ 19 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ( message_dispatcher.cc:48 )
[ 20 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*) ( multiplex_router.cc:710 )
[ 21 ] mojo::MessageDispatcher::Accept(mojo::Message*) ( message_dispatcher.cc:43 )
[ 22 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 23 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 24 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 25 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 26 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 27 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 28 ] base::MessagePumpCFRunLoopBase::RunWork() ( message_pump_apple.mm:444 )
[ 29 ] invocation function for block in base::MessagePumpCFRunLoopBase::RunWorkSource(void*) ( message_pump_apple.mm:416 )
[ 30 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 31 ] 0x1893c9cf8

Expected result:

Not crashing

The text was updated successfully, but these errors were encountered:

bsclifton · 2024-01-18T21:11:44Z

This is the bit of problematic code here:
https://github.com/brave/brave-core/blob/b4278ee85661ba2fa7ab7c43ff0c5b08b9f0917d/browser/brave_vpn/brave_vpn_service_factory.cc#L102-L104

We should be put build flags around the factory and remove the flag for VPN. I'll check that out!

rebron · 2024-01-18T23:24:15Z

Related? #35396

simonhong · 2024-01-22T03:08:39Z

Investigating..

fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.

simonhong · 2024-01-22T06:44:53Z

Related? #35396

Seems different issue. Both have different call stack.

fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.

Fixed crash when account.brav.com is loaded fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated. Also changed to make sure that VPN service factory instance should be created always.

stephendonner · 2024-02-01T19:14:32Z

Just as a datapoint, no crashes here using

Brave | 1.61.114 Chromium: 120.0.6099.199 (Official Build) (arm64)
-- | --
Revision | e0f6e091fe79c029231a86e8cdcc5fbe70bcddbe
OS | macOS Version 13.6.4 (Build 22G513)

(But it's an M1, not an M2, if that makes a difference.)

example	example	example

pavelbrm · 2024-02-02T00:47:12Z

Just as a datapoint, no crashes here using
Brave | 1.61.114 Chromium: 120.0.6099.199 (Official Build) (arm64)
-- | --
Revision | e0f6e091fe79c029231a86e8cdcc5fbe70bcddbe
OS | macOS Version 13.6.4 (Build 22G513)
(But it's an M1, not an M2, if that makes a difference.)

Is the VPN flag on or off? It appears the crash was triggered with the flag off.

stephendonner · 2024-02-02T01:47:38Z

Is the VPN flag on or off? It appears the crash was triggered with the flag off.

It was off; thanks for the clarification/reminder. I can now reproduce 100% using the same build, but with Brave VPN disabled via brave://flags:

example	example	example

Crash ID is: 328e0300-dba3-700b-0000-000000000000

[ 00 ] KeyedServiceFactory::GetServiceForContext(void*, bool) ( keyed_service_factory.cc:69 )
[ 01 ] BrowserContextKeyedServiceFactory::GetServiceForBrowserContext(content::BrowserContext*, bool) ( browser_context_keyed_service_factory.cc:57 )
[ 02 ] brave_vpn::BraveVpnServiceFactory::BindForContext(content::BrowserContext*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_vpn_service_factory.cc:115 )
[ 03 ] brave_vpn::BraveVpnServiceFactory::BindForContext(content::BrowserContext*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_vpn_service_factory.cc:115 )
[ 04 ] (anonymous namespace)::MaybeBindBraveVpnImpl(content::RenderFrameHost*, mojo::PendingReceiver<brave_vpn::mojom::ServiceHandler>) ( brave_content_browser_client.cc:455 )
[ 05 ] base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>)>::Run(content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>) const & ( callback.h:337 )
[ 06 ] void mojo::internal::BinderContextTraits<content::RenderFrameHost*>::BindGenericReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<side_panel::customize_chrome::mojom::WallpaperSearchHandler>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>) ( binder_map_internal.h:40 )
[ 07 ] void base::internal::FunctorTraits<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), void>::Invoke<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:631 )
[ 08 ] void base::internal::InvokeHelper<false, void, 0ul>::MakeItSo<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:868 )
[ 09 ] void base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>>, void (content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>)>::RunImpl<void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, 0ul>(void (* const&)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), std::__Cr::tuple<base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>> const&, std::__Cr::integer_sequence<unsigned long, 0ul>, content::RenderFrameHost*&&, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:968 )
[ 10 ] base::internal::Invoker<base::internal::BindState<void (*)(base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)> const&, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>), base::RepeatingCallback<void (content::RenderFrameHost*, mojo::PendingReceiver<image_annotation::mojom::Annotator>)>>, void (content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>)>::Run(base::internal::BindStateBase*, content::RenderFrameHost*, mojo::ScopedHandleBase<mojo::MessagePipeHandle>&&) ( bind_internal.h:932 )
[ 11 ] mojo::BinderMapWithContext<content::RenderFrameHost*>::TryBind(content::RenderFrameHost*, mojo::GenericPendingReceiver*) ( callback.h:337 )
[ 12 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::BindInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:88 )
[ 13 ] mojo::BinderMapWithContext<content::RenderFrameHost*>::TryBind(content::RenderFrameHost*, mojo::GenericPendingReceiver*) ( callback.h:337 )
[ 14 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::BindInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:88 )
[ 15 ] content::BrowserInterfaceBrokerImpl<content::RenderFrameHostImpl, content::RenderFrameHost*>::GetInterface(mojo::GenericPendingReceiver) ( browser_interface_broker_impl.h:60 )
[ 16 ] blink::mojom::BrowserInterfaceBrokerStubDispatch::Accept(blink::mojom::BrowserInterfaceBroker*, mojo::Message*) ( browser_interface_broker.mojom.cc:180 )
[ 17 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ( message_dispatcher.cc:48 )
[ 18 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*) ( multiplex_router.cc:710 )
[ 19 ] mojo::internal::MultiplexRouter::ProcessIncomingMessage(mojo::internal::MultiplexRouter::MessageWrapper*, mojo::internal::MultiplexRouter::ClientCallBehavior, base::SequencedTaskRunner*) ( message_dispatcher.cc:48 )
[ 20 ] mojo::internal::MultiplexRouter::Accept(mojo::Message*) ( multiplex_router.cc:710 )
[ 21 ] mojo::MessageDispatcher::Accept(mojo::Message*) ( message_dispatcher.cc:43 )
[ 22 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 23 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 24 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 25 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWorkImpl(base::LazyNow*) ( callback.h:154 )
[ 26 ] base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:326 )
[ 27 ] non-virtual thunk to base::sequence_manager::internal::ThreadControllerWithMessagePumpImpl::DoWork() ( thread_controller_with_message_pump_impl.cc:0 )
[ 28 ] base::MessagePumpCFRunLoopBase::RunWork() ( message_pump_apple.mm:444 )
[ 29 ] invocation function for block in base::MessagePumpCFRunLoopBase::RunWorkSource(void*) ( message_pump_apple.mm:416 )
[ 30 ] base::apple::CallWithEHFrame(void () block_pointer)
[ 31 ] 0x18f48a5a8

pavelbrm · 2024-02-02T01:54:14Z

I can now reproduce 100% using the same build, but with Brave VPN disabled via brave://flags

Yes, that's what I meant.

stephendonner · 2024-02-05T19:08:00Z

Verified `PASSED` using

Brave | 1.64.47 Chromium: 121.0.6167.139 (Official Build) nightly (arm64)
-- | --
Revision | 5b6c78859ffd7e8695becfaf714ba9bd19e82bb1
OS | macOS Version 13.6.4 (Build 22G513)

Steps:

installed 1.64.47
launched Brave
disabled Brave VPN via brave://flags
loaded account.brave.com
entered isssue35395@mailinator.com

Confirmed I could log in to `account.brave.com` while `Brave VPN` is disabled, without crashing

`brave://flags`	`logged in`

stephendonner · 2024-03-07T01:21:54Z

Verifed `PASSED` using

Brave | 1.64.96 Chromium: 122.0.6261.111 (Official Build) beta (x86_64)
-- | --
Revision | fb9feca2d1f25ea20265752e8ecdf548a6925bd4
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

installed 1.64.96
launched Brave
disabled Brave VPN via brave://flags
loaded account.brave.com
entered issue35395@mailinator.com

Confirmed I could log in to `account.brave.com` while `Brave VPN` is disabled, without crashing

example	example	example

bsclifton added crash OS/Desktop feature/SKUs labels Jan 18, 2024

bsclifton changed the title ~~Crash on new profile~~ Crash on new profile logging into account.brave.com Jan 18, 2024

bsclifton added the OS/macOS label Jan 18, 2024

bsclifton changed the title ~~Crash on new profile logging into account.brave.com~~ Crash on new profile logging into account.brave.com Jan 18, 2024

bsclifton removed the feature/SKUs label Jan 18, 2024

bsclifton self-assigned this Jan 18, 2024

rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Jan 18, 2024

rebron added this to To do in Crashes via automation Jan 18, 2024

simonhong self-assigned this Jan 22, 2024

simonhong mentioned this issue Jan 22, 2024

Fixed crash when account.brave.com is loaded brave/brave-core#21671

Merged

24 tasks

simonhong mentioned this issue Jan 23, 2024

Infinite spinning from loading account.brave.com confirmation link #35508

Closed

simonhong closed this as completed in brave/brave-core#21671 Jan 23, 2024

Crashes automation moved this from To do to Done Jan 23, 2024

brave-builds added this to the 1.64.x - Nightly milestone Jan 23, 2024

simonhong added QA/Yes release-notes/include labels Jan 24, 2024

stephendonner added the QA/Test-Plan-Specified label Feb 1, 2024

stephendonner added QA Pass-macOS QA Pass-macOS-arm64 and removed QA Pass-macOS labels Feb 5, 2024

stephendonner added the QA Pass-macOS label Mar 7, 2024

LaurenWags mentioned this issue Mar 18, 2024

Desktop Release Notes for 1.64.x Release #36895

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Crash on new profile logging into `account.brave.com` #35395

Crash on new profile logging into `account.brave.com` #35395

bsclifton commented Jan 18, 2024 •

edited

bsclifton commented Jan 18, 2024

rebron commented Jan 18, 2024

simonhong commented Jan 22, 2024

simonhong commented Jan 22, 2024

stephendonner commented Feb 1, 2024

pavelbrm commented Feb 2, 2024 •

edited

stephendonner commented Feb 2, 2024 •

edited

pavelbrm commented Feb 2, 2024

stephendonner commented Feb 5, 2024

stephendonner commented Mar 7, 2024

Crash on new profile logging into account.brave.com #35395

Crash on new profile logging into account.brave.com #35395

Comments

bsclifton commented Jan 18, 2024 • edited

Description

Steps to Reproduce

Actual result:

Expected result:

bsclifton commented Jan 18, 2024

rebron commented Jan 18, 2024

simonhong commented Jan 22, 2024

simonhong commented Jan 22, 2024

stephendonner commented Feb 1, 2024

pavelbrm commented Feb 2, 2024 • edited

stephendonner commented Feb 2, 2024 • edited

pavelbrm commented Feb 2, 2024

stephendonner commented Feb 5, 2024

Verified PASSED using

Steps:

Confirmed I could log in to account.brave.com while Brave VPN is disabled, without crashing

stephendonner commented Mar 7, 2024

Verifed PASSED using

Steps:

Confirmed I could log in to account.brave.com while Brave VPN is disabled, without crashing

Crash on new profile logging into `account.brave.com` #35395

Crash on new profile logging into `account.brave.com` #35395

bsclifton commented Jan 18, 2024 •

edited

pavelbrm commented Feb 2, 2024 •

edited

stephendonner commented Feb 2, 2024 •

edited

Verified `PASSED` using

Confirmed I could log in to `account.brave.com` while `Brave VPN` is disabled, without crashing

Verifed `PASSED` using

Confirmed I could log in to `account.brave.com` while `Brave VPN` is disabled, without crashing