-
Notifications
You must be signed in to change notification settings - Fork 2.2k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Crash on new profile logging into account.brave.com
#35395
Comments
account.brave.com
This is the bit of problematic code here: We should be put build flags around the factory and remove the flag for VPN. I'll check that out! |
Related? #35396 |
Investigating.. |
fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.
Seems different issue. Both have different call stack. |
fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.
fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.
fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated.
Fixed crash when account.brav.com is loaded fix brave/brave-browser#35395 When VPN feature flag is disabled, SkusJSHandler should not try to bind to vpn service handler as BraveVpnService is not instantiated. Also changed to make sure that VPN service factory instance should be created always.
Is the VPN flag on or off? It appears the crash was triggered with the flag off. |
Yes, that's what I meant. |
Verified
|
brave://flags |
logged in |
---|---|
Verifed
|
example | example | example |
---|---|---|
Description
@pavelbrm reported in Slack. He has a Mac with M2 Pro processor running macOS Sonoma.
Crash seems to be related to VPN service when getting the keyed service for this browser instance. Private window is fine because SKU SDK and VPN service are not created for private profile.
For the code in Brave, the last call is here:
https://github.com/brave/brave-core/blob/b4278ee85661ba2fa7ab7c43ff0c5b08b9f0917d/browser/brave_vpn/brave_vpn_service_factory.cc#L114-L115
That calls into Chromium code here:
https://source.chromium.org/chromium/chromium/src/+/main:components/keyed_service/content/browser_context_keyed_service_factory.cc;l=54-57;drc=12be03159fe22cd4ef291e9561762531c2589539
Seems last recorded call in stack is here:
https://source.chromium.org/chromium/chromium/src/+/main:components/keyed_service/core/keyed_service_factory.cc;l=69;drc=8a6d4b6a266bd766e44387a83b09df5a03eea32f
Error is
EXC_BAD_ACCESS / KERN_INVALID_ADDRESS
Steps to Reproduce
1.61.114
or1.61.116
(others may crash too)Actual result:
Crashes. Here are a few crash IDs
And here is one loaded in backtrace (loadable by Brave employees)
https://brave.sp.backtrace.io/p/brave/debug?filters=JTVCJTVCJTIyX3J4aWQlMjIlMkMlMjJlcXVhbCUyMiUyQyUyMjI5MjgwZTAwLTQ2ZmItNTQwYi0wMDAwLTAwMDAwMDAwMDAwMCUyMiU1RCU1RA%3D%3D&fingerprint=a7674ea25794ca9032868af27f09c2828ea69ccc6bd6da434beb126e1c48c905&debug=(%2265f4bdd%22,0,0)
Expected result:
Not crashing
The text was updated successfully, but these errors were encountered: