Hover effect on Bookmarks bar is barely visible

[Skyyie]

After the new update, if we hover the cursor over bookmarks, there is barely any hover effect. I mean, it is barely visible. It is a bit visible in light themes but it is barely there with dark mode.

You can see an example here when I have my cursor over a bookmark folder (i.e., Dashboards):

I am on stable channel and it is the same since v1.62.153 (I am currently in v1.62.156).

Thread on Brave Community: https://community.brave.com/t/hover-effect-on-bookmarks-bar-is-barely-visible-on-latest-update/528225

[simonhong]

checking.
It's hover color should be same as toolbar button's as both have same background color.

[sangwoo108]

Yeah, looks like the inkdrop layer is painted over the bookmark button's label. I guess the difference between chromium and ours would be the base color, which is white in Chromium, and black in ours?

Easy solution would be make bookmark buttons' label have transparent layer so that the layer can be painted atop the ink drop layer

BookmarkMenuButtonBase::BookmarkMenuButtonBase(PressedCallback callback,
                                               const std::u16string& title)
    : MenuButton(std::move(callback), title) {
...
  label()->SetPaintToLayer();
  label()->SetSubpixelRenderingEnabled(false);
  label()->layer()->SetFillsBoundsOpaquely(false);

[stephendonner]

Verification PASSED using

Brave | 1.66.56 Chromium: 123.0.6312.86 (Official Build) nightly (64-bit)
-- | --
Revision | 029ff6b82a6cfb16bde7c6d7ab560321a023cb8b
OS | Windows 10 Version 22H2 (Build 19045.4239)

Steps:

1. installed 1.66.56
2. launched Brave
3. loaded a few websites, and saved their bookmarks on the bookmarks toolbar
4. in Dark mode, took stock of default, on-hover (folder) and on-hover (bookmark) behavior
5. switched to Light mode via brave://settings/appearance
6. took stock of default, on-hover (folder) and on-hover (bookmark) behavior

Confirmed slightly darker, visible hover effects on both folders and bookmarks

Dark mode

default	on-hover, folder	on-hover, bookmark

Light mode

default	on-hover, folder	on-hover, bookmark