Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong transparent part extracted from the unified address #35883

Closed
srirambv opened this issue Feb 8, 2024 · 1 comment · Fixed by brave/brave-core#21960
Closed

Wrong transparent part extracted from the unified address #35883

srirambv opened this issue Feb 8, 2024 · 1 comment · Fixed by brave/brave-core#21960
Assignees
@cypt4
Labels
bug feature/web3/wallet/core feature/web3/wallet/zcash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Milestone
1.64.x - Release

Comments

@srirambv
Copy link
Contributor

srirambv commented Feb 8, 2024

Description

Sending transaction to Unified address shows sucess but balance doesn't update

Steps to Reproduce

  1. Submit a transaction to Unified address that includes transparent address
  2. Transaction is successful
  3. Check balance of unified address, doesn't show the transfer balance

Actual result:

Sending transaction to Unified address shows sucess but balance doesn't update

Expected result:

Should show the balance

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 1.64.53 Chromium: 121.0.6167.139 (Official Build) nightly (64-bit)
Revision 191f7f23eaab918ac1a55a8328b891350364ca73
OS Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release? NA
  • Can you reproduce this issue with the beta channel? NA
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @cypt4
@srirambv srirambv changed the title Sending transaction to Unified address shows sucess but balance doesn't update Sending transaction to Unified address shows success but balance doesn't update Feb 8, 2024
cypt4 added a commit to brave/brave-core that referenced this issue Feb 8, 2024
@cypt4
Extract transparent part using pubkey hash instead of pubkey in UA
ea869d7 
Resolves brave/brave-browser#35883
@cypt4 cypt4 mentioned this issue Feb 8, 2024
Merged
24 tasks
cypt4 added a commit to brave/brave-core that referenced this issue Feb 8, 2024
@cypt4
Extract transparent part using pubkey hash instead of pubkey in UA
381fa63 
Resolves brave/brave-browser#35883
cypt4 added a commit to brave/brave-core that referenced this issue Feb 9, 2024
@cypt4
Extract transparent part using pubkey hash instead of pubkey in UA (#…
3171408 
…21960)

* Extract transparent part using pubkey hash instead of pubkey in UA
Resolves brave/brave-browser#35883
@brave-builds brave-builds added feature/web3/wallet Integrating Ethereum+ wallet support feature/web3/wallet/core labels Feb 9, 2024
@brave-builds brave-builds added this to the 1.64.x - Nightly milestone Feb 9, 2024
@cypt4 cypt4 self-assigned this Feb 9, 2024
@cypt4 cypt4 changed the title Sending transaction to Unified address shows success but balance doesn't update Wrong transparent part extracted from the unified address Feb 9, 2024
@cypt4 cypt4 mentioned this issue Feb 9, 2024
Open
@srirambv
Copy link
Contributor Author

Verification passed on

Brave 1.64.104 Chromium: 123.0.6312.46 (Official Build) (64-bit)
Revision 0ca3d372cf8aab96fafdd75f5c5c8d2012bc0cc6
OS Windows 11 Version 23H2 (Build 22631.3296)
  • Verified steps from issue description
  • Verified correct transparent is extracted from unified address and balance updates after transaction is confirmed

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cypt4 cypt4

Labels
bug feature/web3/wallet/core feature/web3/wallet/zcash feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Web3
Archived in project
Milestone
1.64.x - Release
Development

Successfully merging a pull request may close this issue.

Extract transparent part using pubkey hash instead of pubkey in UA brave/brave-core
3 participants
@srirambv @brave-builds @cypt4