Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Desktop] Support fingerprint webauthn on macOS #3642

Closed
corymcdonald opened this issue Mar 8, 2019 · 16 comments · Fixed by brave/brave-core#5539
Closed

[Desktop] Support fingerprint webauthn on macOS #3642

corymcdonald opened this issue Mar 8, 2019 · 16 comments · Fixed by brave/brave-core#5539
Assignees
@jumde
Labels
OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Security & Privacy
Milestone
1.11.x - Release #1

Comments

@corymcdonald
Copy link

corymcdonald commented Mar 8, 2019 •
edited by jumde

Description

For publishers we received a request from @tomlowenthal to implement webauthn as a sign in provider. However in the current release of Brave webauthn is not supported

https://webauthn.bin.coffee
https://webauthndemo.appspot.com

Actual result:

On the webauthn.bin.coffee site when you try and generate a login

Contacting token... please perform your verification gesture (e.g., touch it, or plug it in)

Note: Raw response in console.
Got error:
TypeError: Cannot read property 'response' of null

Failures: 1 TODOs: 0

Expected result:

webauthn successfully works when trying to authenticate with a fingerprint reader

Reproduces how often:

Everytime

Brave version (brave://version info)

All versions.

Test Plan

Specified here: brave/brave-core#5539

Additional Information

Essentially think it's related to removing credentialManager
brave/brave-core#1896
@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. webcompat/not-shields-related Sites are breaking because of something other than Shields. labels Mar 8, 2019
@tildelowengrimm tildelowengrimm added this to To do in Web Compatibility via automation Mar 8, 2019
@tildelowengrimm tildelowengrimm added this to Untriaged Backlog in Security & Privacy via automation Mar 8, 2019
@rebron rebron added this to Untriaged Backlog in General Mar 11, 2019
@rebron rebron moved this from Untriaged Backlog to P3 & P4 Backlog in General Mar 12, 2019
@rebron rebron moved this from P4 Backlog to P3 Backlog in General Mar 14, 2019
@bbondy
Copy link
Member

bbondy commented Mar 15, 2019

@corymcdonald I think this is working with our 0.61.x release with Chromium 73. Could you try?

@bbondy
Copy link
Member

bbondy commented Mar 15, 2019

I think this fixes it actually which is live:
brave/brave-core#1899

@corymcdonald
Copy link
Author

I was able to get Yubikey to work in both

  • Version 0.61.51 Chromium: 73.0.3683.75 (Official Build) (64-bit)
  • Version 0.63.13 Chromium: 73.0.3683.75 (Official Build) dev (64-bit)

However I was not able to use my fingerprint as a way for UTF. So maybe this issue should be made a little more specific?

@bsclifton
Copy link
Member

bsclifton commented Mar 18, 2019 •
edited

@corymcdonald please do update the issue to cover your case 😄 (title, original post details)

@corymcdonald corymcdonald changed the title Support webauthn Support fingerprint webauthn on OSX Mar 18, 2019
@rebron rebron moved this from To do to P3 & P4 backlog in Web Compatibility Apr 2, 2019
@mikegrima
Copy link

Not sure if this is related to this issue, or if I should submit a new one. Touch ID currently does not work for webauthn for the latest Brave release (it does work in Chrome).

To replicate, try using Touch ID on https://webauthn.me. I think one of the issues is that Brave does not ask you to permit the site access to Touch ID, which Chrome does. Because of this, Touch ID doesn't work :(

@corymcdonald
Copy link
Author

This is still an issue. 😄 We want to support WebAuthn on the publishers so it would be nice to get this somewhere on the roadmap so it would be released on the Release version before the end of year @rebron

@mikegrima
Copy link

mikegrima commented Jun 13, 2019 •
edited

It's really unfortunate that I can't use TouchID on Brave. Implementing this would have full feature parity with Chrome (from my perspective :)).

@rebron rebron removed this from P3 Backlog in General Jun 13, 2019
@rebron rebron removed this from P3 backlog in Web Compatibility Jun 13, 2019
@rebron rebron added priority/P4 Planned work. We expect to get to it "soon". and removed priority/P3 The next thing for us to work on. It'll ride the trains. labels Jun 13, 2019
@fmarier fmarier moved this from Untriaged Backlog to P3, P4, & P5 Backlog in Security & Privacy Jun 25, 2019
@MattDierick
Copy link

Same comment, WebAuthn is more and more used by IDaaS and MFA like Duo or OKTA.

@ChadKillingsworth
Copy link

Github has now enabled this functionality and next month over a hundred banks and credit unions will have it enabled for their sites. Really need this enabled.

@kimbim
Copy link

kimbim commented Nov 18, 2019

Need this to switch to Brave!

@stgarf
Copy link

stgarf commented Jan 24, 2020 •
edited

I'd like this support added to Brave to continue using Brave at work since we've switched to Okta Verify with Touch ID for authentication. This works correctly in Chrome.

@bmreilly
Copy link

I'm required to use Duo to login at work - as are many others - without touchID i have to pull my phone out >20x a day to verify. This is causing me to seriously contemplate switching back to chrome....

@evanmhm
Copy link

evanmhm commented Feb 15, 2020

I am also using Duo for school and I really wish I could use touchID in Brave :/

@tildelowengrimm tildelowengrimm added priority/P3 The next thing for us to work on. It'll ride the trains. and removed priority/P4 Planned work. We expect to get to it "soon". labels Apr 27, 2020
@MartinCanovas
Copy link

Many business use Okta for authentication and it would be great for the Brave community to have Touch ID supported.

@jumde
Copy link
Contributor

jumde commented May 8, 2020

Work in progress! Stay tuned 😄

@jumde jumde mentioned this issue May 13, 2020
Merged
32 tasks
Security & Privacy automation moved this from P3, P4, & P5 Backlog to Completed May 15, 2020
@jumde jumde modified the milestones: 1.10.x - Beta, 1.11.x - Nightly May 15, 2020
@LaurenWags
Copy link
Member

LaurenWags commented Jun 18, 2020 •
edited by kjozwiak

Verified passed on macOS 10.14.6 Mojave using

Brave | 1.11.68 Chromium: 83.0.4103.106 (Official Build) dev (64-bit)
-- | --
Revision | ce7134bb3d95141cd18f1e65772a4247f282d950-refs/branch-heads/4103@{#694}
OS | macOS Version 10.14.6 (Build 18G3020)

1 10 93 reproduce

  • Confirmed using 1.11.x touch ID is requested:

Screen Shot 2020-06-18 at 11 37 01 AM

  • Confirmed able to complete the flow using either touch ID or yubikey on demo.yubico.com/u2f

cc @kjozwiak to check on Catalina

Verification PASSED on macOS 10.15.5 x64 using the following build:

Brave | 1.11.80 Chromium: 83.0.4103.116 (Official Build) dev (64-bit)
-- | --
Revision | 8f0c18b4dca9b6699eb629be0f51810c24fb6428-refs/branch-heads/4103@{#716}
OS | macOS Version 10.15.5 (Build 19F101)

Screen Shot 2020-06-29 at 11 57 21 PM

Screen Shot 2020-06-29 at 11 57 31 PM

@rebron rebron changed the title Support fingerprint webauthn on OSX [Desktop] Support fingerprint webauthn on macOS Jul 14, 2020
@LaurenWags LaurenWags mentioned this issue Jul 15, 2020
Closed
@jumde jumde mentioned this issue Sep 15, 2020
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@jumde jumde

Labels
OS/macOS priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-macOS QA/Test-Plan-Specified QA/Yes release-notes/include webcompat/not-shields-related Sites are breaking because of something other than Shields.
Projects
Security & Privacy
  
Completed
Milestone
1.11.x - Release #1
Development

Successfully merging a pull request may close this issue.

Fix 3642: Add support for touchID webauthn brave/brave-core