Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix 3642: Add support for touchID webauthn #5539

Merged
merged 1 commit into from May 15, 2020
Merged

Fix 3642: Add support for touchID webauthn #5539

merged 1 commit into from May 15, 2020

Conversation

jumde
Copy link
Contributor

@jumde jumde commented May 13, 2020

Resolves brave/brave-browser#3642

Submitter Checklist:

Test Plan:

  1. Navigate to demo.yubico.com/u2f
  2. Start the webauthn workflow
  3. Verify that webauthn workflow completes with built-in touch id.

Reviewer Checklist:

  • New files have MPL-2.0 license header.
  • Request a security/privacy review as needed.
  • Adequate test coverage exists to prevent regressions
  • Verify test plan is specified in PR before merging to source

After-merge Checklist:

  • The associated issue milestone is set to the smallest version that the
    changes has landed on.
  • All relevant documentation has been updated.

@jumde jumde requested a review from bridiver as a code owner May 13, 2020 05:57
@jumde jumde self-assigned this May 13, 2020
@jumde jumde force-pushed the touchid_webauthn branch 3 times, most recently from 78a7b77 to f1f26d7 Compare May 14, 2020 04:04
@jumde jumde merged commit 614a96f into master May 15, 2020
@jumde jumde deleted the touchid_webauthn branch May 15, 2020 02:01
@jumde jumde added this to the 1.11.x - Nightly milestone May 28, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
2 participants