Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Wrong sidebar add item button position #36500

Closed
simonhong opened this issue Mar 1, 2024 · 1 comment · Fixed by brave/brave-core#22413
Closed

Wrong sidebar add item button position #36500

simonhong opened this issue Mar 1, 2024 · 1 comment · Fixed by brave/brave-core#22413
Assignees
@simonhong
Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Milestone
1.65.x - Release

Comments

@simonhong
Copy link
Member

Description

image

Steps to Reproduce

Actual result:

Expected result:

image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release? Yes
  • Can you reproduce this issue with the beta channel? Yes
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:
@simonhong simonhong added bug priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/include OS/Desktop feature/sidebar Relating to Brave's Sidebar feature labels Mar 1, 2024
@simonhong simonhong self-assigned this Mar 1, 2024
@simonhong simonhong added this to In progress in General Mar 1, 2024
simonhong added a commit to brave/brave-core that referenced this issue Mar 1, 2024
@simonhong
Fixed wrong sidebar add item button
dcb1238 
fix brave/brave-browser#36500
@simonhong simonhong mentioned this issue Mar 1, 2024
Merged
24 tasks
General automation moved this from In progress to Completed Mar 4, 2024
@brave-builds brave-builds added this to the 1.65.x - Nightly milestone Mar 4, 2024
@stephendonner
Copy link
Collaborator

Verified PASSED using

Brave | 1.65.80 Chromium: 123.0.6312.29 (Official Build) nightly (64-bit)
-- | --
Revision | cd0c2b9c6f07e8f01724294c8d7e37393a8c3a38
OS | Windows 10 Version 22H2 (Build 19045.4170)

Steps:

  1. installed 1.65.80
  2. launched Brave
  3. checked the Sidebar's icon strip

Confirmed the + icon is directly below the Reading List icon on the sidebar

image

@LaurenWags LaurenWags mentioned this issue Apr 15, 2024
Closed
@rebron rebron removed this from Completed in General Apr 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
bug feature/sidebar Relating to Brave's Sidebar feature OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass-Win64 QA/Yes release-notes/include
Projects
None yet
Milestone
1.65.x - Release
Development

Successfully merging a pull request may close this issue.

Fixed wrong sidebar add item button brave/brave-core
3 participants
@stephendonner @simonhong @brave-builds