Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Leo search overlay entry point should be at the bottom of the list #37263

Closed
iccub opened this issue Apr 2, 2024 · 2 comments · Fixed by brave/brave-core#22879
Closed

Leo search overlay entry point should be at the bottom of the list #37263

iccub opened this issue Apr 2, 2024 · 2 comments · Fixed by brave/brave-core#22879
Assignees
@iccub
Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-iPhone X QA/Yes release-notes/include
Milestone
1.64.x - Release #4

Comments

@iccub
Copy link

iccub commented Apr 2, 2024

Platform parity, other platforms have it at the bottom, iOS has it at the top
@iccub iccub added priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes OS/iOS Fixes related to iOS browser functionality labels Apr 2, 2024
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay at the bottom.
2576b2f 
Resolves brave/brave-browser#37263
@iccub iccub mentioned this issue Apr 2, 2024
Merged
24 tasks
@iccub iccub self-assigned this Apr 2, 2024
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay at the bottom.
e71bd9f 
Resolves brave/brave-browser#37263
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay at the bottom.
184f768 
Resolves brave/brave-browser#37263
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)
d686496 
Resolves brave/brave-browser#37263
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)
1c01d22 
Resolves brave/brave-browser#37263
@iccub iccub mentioned this issue Apr 2, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue Apr 2, 2024
@iccub
[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)
f0cef7a 
Resolves brave/brave-browser#37263
@iccub iccub mentioned this issue Apr 2, 2024
Merged
24 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue Apr 5, 2024
@iccub
[iOS] Move Leo entry point on the search overlay to the bottom. (Upli…
5a36db9 
…ft to 1.65.x) (#22889)

[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)

Resolves brave/brave-browser#37263
kjozwiak pushed a commit to brave/brave-core that referenced this issue Apr 5, 2024
@iccub
[iOS] Move Leo entry point on the search overlay to the bottom. (Upli…
3d33039 
…ft to 1.64.x) (#22888)

[iOS] Move Leo entry point on the search overlay to the bottom. (#22879)

Resolves brave/brave-browser#37263
@kjozwiak kjozwiak mentioned this issue Apr 5, 2024
Closed
25 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Apr 5, 2024

The above requires 1.64.118 or higher for 1.64.x verification 👍

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Apr 8, 2024
@Uni-verse
Copy link
Contributor

Verified on iPhone X running iOS 16.7 using version 1.64.119

  • Ensured Leo search suggestion appears at the bottom of the overlay.
  • Ensured Leo is at the bottom of the overlay using top and bottom modes.
  • Ensured Leo is launched when using the search overlay entry point.
Example Example Example
IMG_3733 IMG_3734 IMG_3735 2

@Uni-verse Uni-verse added QA Pass-iPhone X and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Apr 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@iccub iccub

Labels
browser-ai OS/iOS Fixes related to iOS browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-iPhone X QA/Yes release-notes/include
Projects
None yet
Milestone
1.64.x - Release #4
Development

Successfully merging a pull request may close this issue.

[iOS] Move Leo entry point on the search overlay to the bottom. brave/brave-core
4 participants
@kjozwiak @iccub @Uni-verse @brave-builds