Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude crypto address only sites/channels from Auto-Contribute #37464

Closed
Miyayes opened this issue Apr 10, 2024 · 4 comments · Fixed by brave/brave-core#23052
Closed

Exclude crypto address only sites/channels from Auto-Contribute #37464

Miyayes opened this issue Apr 10, 2024 · 4 comments · Fixed by brave/brave-core#23052

Comments

@Miyayes
Copy link
Collaborator

Miyayes commented Apr 10, 2024

Description

If a site/channel only has crypto addresses (Ethereum and/or Solana address) but NO custodial account address, it should NOT be added to the Auto-Contribute list.

@Miyayes Miyayes added feature/rewards OS/Android Fixes related to Android browser functionality OS/Desktop labels Apr 10, 2024
@Miyayes Miyayes added this to New Issues in Brave Rewards via automation Apr 10, 2024
Brave Rewards automation moved this from New Issues to Done Apr 16, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 16, 2024
@LaurenWags
Copy link
Member

Added QA/Blocked per discussion via https://bravesoftware.slack.com/archives/CB0KCRCQN/p1716208636885399

@LaurenWags
Copy link
Member

Removing QA/Blocked as we now have the needed set up per https://bravesoftware.slack.com/archives/CB0KCRCQN/p1716301177255669?thread_ts=1716208636.885399&cid=CB0KCRCQN.

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2024

Verification PASSED on

Brave | 1.67.90 Chromium: 125.0.6422.60 (Official Build) beta (64-bit)
-- | --
Revision | 64f9eec1a854079c3e529e908ca300071afb1f32
OS | Windows 10 Version 22H2 (Build 19045.4412)

  • Verified the test plan from Exclude web3-only creators from AC list brave-core#23052
  • Confirmed that the web3-only verified publisher shredshark.ca is not added to the AC table
  • Confirmed that Uphold and Gemini publishers are added to the AC list (not able to add bitFlyer publisher alexvincentmusic.com as the pubs doesn't load due to redirect issue)
  • Confirmed that Attention and Include in Auto-contribute switch is not present in the BR panel for the web3-only verified publisher shredshark.ca
  • Confirmed that AC is performed for the publishers that are added in AC table
web3-only Gemini Uphold AC table
image image image image
Example Example Example
image image image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 23, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 23, 2024

Verification PASSED on Samsung galaxy version 12 running Bravemonaoarm64.apk_1.67.90

web3-only Gemini Uphold AC table
Screenshot_20240523_201923_Brave - Beta Screenshot_20240523_202108_Brave - Beta Screenshot_20240523_202336_Brave - Beta Screenshot_20240523_203021_Brave - Beta
Example Example Example
Screenshot_20240622_211411_Brave - Beta Screenshot_20240622_211429_Brave - Beta Screenshot_20240622_211457_Brave - Beta

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Brave Rewards
  
Done
Development

Successfully merging a pull request may close this issue.

5 participants