Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Exclude web3-only creators from AC list #23052

Merged
merged 1 commit into from
Apr 16, 2024
Merged

Conversation

zenparsing
Copy link
Collaborator

@zenparsing zenparsing commented Apr 12, 2024

Resolves brave/brave-browser#37464

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

  • With a connected Rewards profile:
  • Visit a creator page that is web3-only.
  • Wait for 10 seconds.
  • Open the Rewards page.
  • Verify that the site does not appear in the Auto-Contribute list.

@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label Apr 12, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing marked this pull request as ready for review April 16, 2024 14:37
@zenparsing zenparsing requested a review from a team as a code owner April 16, 2024 14:37
Copy link
Contributor

@emerick emerick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved, one minor nit.

components/brave_rewards/core/publisher/publisher.cc Outdated Show resolved Hide resolved
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

@zenparsing zenparsing merged commit b7142cf into master Apr 16, 2024
19 checks passed
@zenparsing zenparsing deleted the ksmith-sol-no-ac-list branch April 16, 2024 18:05
@github-actions github-actions bot added this to the 1.67.x - Nightly milestone Apr 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Exclude crypto address only sites/channels from Auto-Contribute
3 participants