Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Strip Salesforce Marketing Cloud email tracker #37847

Closed
fmarier opened this issue Apr 24, 2024 · 2 comments · Fixed by brave/brave-core#23275
Closed

Strip Salesforce Marketing Cloud email tracker #37847

fmarier opened this issue Apr 24, 2024 · 2 comments · Fixed by brave/brave-core#23275

Comments

@fmarier
Copy link
Member

fmarier commented Apr 24, 2024

It looks like Salesforce Marketing Cloud is the product responsible for adding et_cid and et_rid to URLs, but I also found the occasional et_lid parameter in the wild:

This page shows that et_cid is a campaign ID and this one suggests that et_rid is related to an individual email subscriber.

We should therefore strip et_rid by default.

@fmarier fmarier added OS/Android Fixes related to Android browser functionality OS/Desktop privacy/query-filter labels Apr 24, 2024
@fmarier fmarier added this to Untriaged Backlog in Security & Privacy via automation Apr 24, 2024
@fmarier fmarier self-assigned this Apr 24, 2024
@fmarier fmarier moved this from Untriaged Backlog to In Progress in Security & Privacy Apr 24, 2024
@fmarier fmarier moved this from In Progress to Pending review in Security & Privacy Apr 25, 2024
Security & Privacy automation moved this from Pending review to Completed Apr 25, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone Apr 25, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.67.49 Chromium: 124.0.6367.91 (Official Build) nightly (64-bit)
-- | --
Revision | f288c3d5f0d3fa6f1bd10fe42174554bfe0275cc
OS | Windows 10 Version 22H2 (Build 19045.4355)

Steps:

  1. installed 1.67.49
  2. launched Brave
  3. ensured Standard set for Trackers & ad blocking in brave://settings/shields
  4. loaded https://brave.com/?et_cid=1234&et_rid=abcd
  5. examined the URL bar

Confirmed et_cid=1234 remained in the URL bar, and et_rid=abcd was stripped out

image

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 3, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 3, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.022 release-keys
Brave build: 1.67.100
Chromium: 125.0.6422.112 (Official Build) beta (64-bit) 

STEPS:

  1. Install and launch Brave
  2. Open Settings > Brave Shields & privacy
  3. Block trackers & ads > Confirm it set to Standard
  4. Close the settings
  5. Go to https://brave.com/?et_cid=1234&et_rid=abcd > Verify

ACTUAL RESULTS:

  • Verified that et_rid parameter is removed, but et_cid is still present when Block trackers & ads is set to Standard

1 2 3
1 2 3

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment