Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Android] Rate brave bottom sheet modal is not fully shown while device is in Landscape mode #37870

Closed
deeppandya opened this issue Apr 26, 2024 · 1 comment · Fixed by brave/brave-core#23299
Assignees
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include

Comments

@deeppandya
Copy link

Description

Rate brave bottom sheet modal is not fully shown while the device is in Landscape mode.

Steps to reproduce

  1. Launch Brave
  2. Go to settings
  3. Rotate the device (phone or tablet) into Landscape mode
  4. Tap on Rate Brave -> Observe

Actual result

Screenshot_2024-04-26-00-34-47-57_82cebf612ef3f9a8762672c971adaed4

Expected result

Screenshot_2024-04-26-00-35-08-28_82cebf612ef3f9a8762672c971adaed4

Issue reproduces how often

Easily

Version/Channel Information:

  • Can you reproduce this issue with the current Play Store version? Yes
  • Can you reproduce this issue with the current Play Store Beta version? Yes
  • Can you reproduce this issue with the current Play Store Nightly version? Yes

Device details

  • Install type (ARM, x86): ARM
  • Device type (Phone, Tablet, Phablet): Phone and Tablet
  • Android version: ANY

Brave version

Brave build: 1.66.70
Chromium: 124.0.6367.29 (Official Build) canary (64-bit)

Website problems only

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Additional information

@deeppandya deeppandya added bug priority/P2 A bad problem. We might uplift this to the next planned release. QA/Yes OS/Android Fixes related to Android browser functionality labels Apr 26, 2024
@deeppandya deeppandya self-assigned this Apr 26, 2024
@brave-builds brave-builds added this to the 1.67.x - Nightly milestone May 1, 2024
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 21, 2024
@hffvld
Copy link
Contributor

hffvld commented May 21, 2024

Verified on Pixel 7 using version(s):

Device/OS: Pixel 7 / panther_beta-user 14 AP31.240426.022 release-keys
Brave build: 1.67.85 
Chromium: 125.0.6422.60 (Official Build) beta (64-bit) 

STEPS:

  1. Follow the steps from [Android] Rate brave bottom sheet modal is not fully shown while device is in Landscape mode #37870 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Rate Brave bottom sheet modal is fully shown in Landscape and Portrait modes
  • Verified that the correct behavior is seen when rotating device while bottom sheet modal is opened already

1 2
1 2
1 2
timestamp_12-56-04_12-56-24.mp4

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA/Yes release-notes/include
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants