Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Incorrect Translation in Simplified Chinese UI #37905

Closed
junkworld opened this issue Apr 27, 2024 · 22 comments · Fixed by brave/brave-core#23768
Closed

Incorrect Translation in Simplified Chinese UI #37905

junkworld opened this issue Apr 27, 2024 · 22 comments · Fixed by brave/brave-core#23768
Assignees
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects

Comments

@junkworld
Copy link

junkworld commented Apr 27, 2024

New private window with tor should be translated as 用Tor打开新的无痕窗口,
not 用Tor打开新的私人窗口.

Also
Settings - Privacy and Security - tor window - private window with tor should be translated as 带tor的无痕窗口,
not 带tor的私人窗口.

Settings - Sheilds - Trackers & ads blocking - option Aggressive should be translated as 积极地 or 主动, not 攻击性.

Settings - Sheilds - Trackers & ads blocking - Allow Facebook logins and embedded posts should be translated as 允许Facebook登陆和嵌入帖子.

Settings - Sheilds - Trackers & ads blocking - Forget me when I close this site should be translated as 关闭此网站后遗忘我, not 关闭此网站后勿扰.
In Chinese, 勿扰 means do not disturb .

Settings - Appearance - Tabs - Tab hover mode, option card should be translated as 卡片, not 信用卡.
In Chinese, 信用卡 means credit card .

@rebron rebron added the l10n label Apr 30, 2024
@rebron rebron added the priority/P2 A bad problem. We might uplift this to the next planned release. label Apr 30, 2024
@rebron
Copy link
Collaborator

rebron commented Apr 30, 2024

Thanks @junkworld

@mkarolin. @larreewong reviewed and the suggestions here are good.

@rebron rebron added the QA/Yes label Apr 30, 2024
@mkarolin
Copy link
Contributor

@rebron

"New private window with tor" should be translated as "用Tor打开新的无痕窗口",
not "用Tor打开新的私人窗口" .

Google translate gives me Open new private window with Tor for the current translation, but for the suggested translation I get Open a new incognito window with Tor.

Also
Settings - Privacy and Security - tor window - "private window with tor " should be translated as "带tor的无痕窗口",
not "带tor的私人窗口".

Similarly, for our current translation Google translate gives me Private window with tor, while the suggested translation shows as Incognito windows with tor.

@rebron
Copy link
Collaborator

rebron commented May 1, 2024

Let's stick with our private language vs incognito.

@mkarolin
Copy link
Contributor

mkarolin commented May 1, 2024

Updated the rest in Transifex. Should get them for the upcoming 1.66.x release.

@junkworld
Copy link
Author

junkworld commented May 1, 2024

Translate private window as 隐私窗口 is a more correct translation,
In Chinese, 私人 means more "Personal", 私人 does not emphasize privacy.

The current situation is that there are too many private window words in brave settings. Some are translated as
无痕窗口 and some are translated as 私人窗口.

They are all the same words private window and have not been unified translated into the same Chinese words.

Incognito window/无痕窗口 is used in Chromium,
I guess since Brave is a fork of Chromium, Brave inherited a lot of the translations in Chromium.

In Firefox, private window is translated as 隐私窗口.

@junkworld

This comment was marked as resolved.

@junkworld

This comment was marked as resolved.

@mkarolin
Copy link
Contributor

mkarolin commented May 1, 2024

Thank you @junkworld.

I've updated the Web Store strings.

With Javascript, that looks like we maybe stripping the leading J programmatically by mistake (cc: @fallaciousreasoning - the translated string is JavaScript 控制台(&J) in app/resources/generated_resources_zh-CN.xtb. We are probably removing the leading J by accident when we strip &J from the translation.)

The private vs incognito issue is not limited to just the Chinese translations. It sounds like we really need a more comprehensive effort to clean up the interchangeable use of these terms in translations @rebron, @AndyAnds265.

@rebron rebron added this to In progress in General May 2, 2024
@junkworld
Copy link
Author

junkworld commented May 2, 2024

I think in Appearance the first Brave colors should be renamed as Brave mode, Which matches the system's light mode and dark mode.

Brave mode should be translated as Brave 模式 in Chinese, Of course Brave mode should also be translated into any other user languages.

截屏2024-05-02 20 29 44 截屏2024-05-02 20 30 12 截屏2024-05-02 20 39 57

@junkworld
Copy link
Author

junkworld commented May 2, 2024

Shields should not be translated, It is most appropriate to use the original English word like Leo and Web3, and the Shields after being translated as 屏蔽 is also an incorrect translation. If Shields must be translated, it should be translated as . In Chinese, 屏蔽 means block, not Shields. I think It is best to use Shields without translation. Just like ublock origin /adguard /adblock plus, they don't need to be translated into other languages.

@junkworld

This comment was marked as resolved.

@junkworld

This comment was marked as resolved.

@junkworld

This comment was marked as resolved.

@mkarolin
Copy link
Contributor

This should be mostly addressed by brave/brave-core#23555

@junkworld
Copy link
Author

junkworld commented May 17, 2024

Hi,
I'm already using the 1.66.110 stable version,
and I'm glad to see that many issues have been fixed.
Except for those that are still not finalized,
there are still some issues that have not been fixed.

Get started - New tab page shows should be translated as 新标签页显示,not 新标签页随及会显示
随及会 three words are grammatically incorrect in Chinese context,confusing and redundant,should be deleted.

Control panel - Brave 的 VPN , should be deleted, when is added,that would change its meaning to Brave's VPN,Brave's VPN and Brave VPN have completely different meanings.
Settings - System - Shortcuts ,These should also be deleted, these are grammatically incorrect in Chinese context.
截屏2024-05-17 20 17 57

Privacy and security - Tor windows - Private window with Tor window should be translated as 窗口, not 窗户.
All these window and windows should be translated as 窗口,somehow,this one is strangely translated as 窗户.
In Chinese context, we use 窗户 to refer to a physical window in a house. This word cannot be used to refer to a window in a computer operating system.
图像

@junkworld
Copy link
Author

junkworld commented May 19, 2024

Hi, @mkarolin

Some new issues here,

System - Shortcuts ,
Duplicate tab/复制标签页
Pin tab/固定标签页
Group tab/组标签页
double quotation mark (“ ”)were added by mistake, these double quotation mark(“ ”) should be deleted.

Group tab should be translated as 分组标签页, not 组标签页

添加 and 重置 should be arranged horizontally,not arranged vertically

截屏2024-05-18 15 06 05

@brave-builds brave-builds added this to the 1.66.x - Release #2 milestone May 21, 2024
@kjozwiak
Copy link
Member

Closing the above as brave/brave-core#23735 was merged into 1.66.x. The above requires 1.66.112 or higher for 1.66.x verification 👍

@GeetaSarvadnya GeetaSarvadnya added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 22, 2024
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 22, 2024

Verification PASSED on

image

  1. Settings - Sheilds - Trackers & ads blocking - option Aggressive should be translated as 积极地 or 主动, not 攻击性. - PASSED
    image
  2. Settings - Sheilds - Trackers & ads blocking - Allow Facebook logins and embedded posts should be translated as 允许Facebook登陆和嵌入帖子. - PASSED
    image
  3. Settings - Sheilds - Trackers & ads blocking - Forget me when I close this site should be translated as 关闭此网站后遗忘我, not 关闭此网站后勿扰. - PASSED
    image
  4. Settings - Appearance - Tabs - Tab hover mode, option card should be translated as 卡片, not 信用卡 - PASSED
    image

@GeetaSarvadnya GeetaSarvadnya added QA Pass-Win64 and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 22, 2024
@junkworld
Copy link
Author

Verification PASSED on
截屏2024-05-23 14 09 15


Verified the Simplified Chinese translations from the description
#37905 (comment)

Get started - New tab page shows should be translated as 新标签页显示,not 新标签页随及会显示
PASSED

截屏2024-05-23 14 10 13

Control panel - Brave 的 VPN , should be deleted
PASSED
Settings - System - Shortcuts ,These should also be deleted
PASSED
截屏2024-05-23 14 11 33
截屏2024-05-23 14 11 45

Privacy and security - Tor windows - Private window with Tor window should be translated as 窗口, not 窗户
PASSED
截屏2024-05-23 14 10 27


Verified the Simplified Chinese translations from the description
#37905 (comment)

System - Shortcuts ,
Duplicate tab/复制标签页
Pin tab/固定标签页
Group tab/组标签页
double quotation mark (“ ”)were added by mistake, these double quotation mark(“ ”) should be deleted.
PASSED
截屏2024-05-23 14 11 55
截屏2024-05-23 14 12 24
截屏2024-05-23 14 12 36

Group tab should be translated as 分组标签页, not 组标签页
NOT PASSED
截屏2024-05-23 14 11 55

添加 and 重置 should be arranged horizontally,not arranged vertically
NOT PASSED
截屏2024-05-23 14 12 11

@mkarolin
Copy link
Contributor

Group tab should be translated as 分组标签页, not 组标签页
@junkworld, forgot to ask you about this .. the original string is for tab (not tabs). Google translate seems to indicate that your suggestion would mean tabs (plural).

添加 and 重置 should be arranged horizontally,not arranged vertically
This is more of a layout issue, rather than a translation issue, so we would need to address that separately. cc: @fallaciousreasoning

@junkworld
Copy link
Author

junkworld commented May 23, 2024

Group tab should be translated as 分组标签页, not 组标签页
@junkworld, forgot to ask you about this .. the original string is for tab (not tabs). Google translate seems to indicate that your suggestion would mean tabs (plural).

添加 and 重置 should be arranged horizontally,not arranged vertically
This is more of a layout issue, rather than a translation issue, so we would need to address that separately. cc: @fallaciousreasoning

@mkarolin

I'm a heavy user of tab groups,I set Ctrl+G for Group tab shortcut,
I found it has the same function as Add tab to New Group,no matter I select one tab, two tabs or more.
Are they the same function?


And let me explain why 组标签页 is incorrect.
When the single word is used as a verb in the Chinese context, there is usually only one usage of 组我组你or组他, which means to 'add me into the team','add you into the team' ,'add him into the team'.
We don't add nouns after a single word ,this is a grammatically wrong sentence in Chinese context,and the plural is not applicable in this sentence in Chinese context,Google translate gives an incorrect translation.
The word is usually used as part of compound words such as
分组:grouping,divide into groups,sectionalization
组织:organize,organization,
组装:assemble,
组合:combination,
组队:form a team,
组建:establish,build

If Group tab has same function as Add tab to New Group ,it is better to use that same translation向新群组中添加标签页 or just use 分组标签页
截屏2024-05-23 22 16 11

@mkarolin
Copy link
Contributor

Hi @junkworld, thank you for the detailed explanation. I will update the translation to 分组标签页 for the next release version. Unfortunately, the text for this command is autogenerated and can't be easily mapped to `Add tab to new group' because of the way that string is constructed in the Chromium code.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
l10n OS/Desktop priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass-Win64 QA/Yes release-notes/exclude
Projects
Status: Completed
General
  
Completed
Development

Successfully merging a pull request may close this issue.

6 participants