Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

"This is a secondary installation of Brave, and cannot be made your default browser." #3817

Closed
tildelowengrimm opened this issue Mar 20, 2019 · 2 comments · Fixed by brave/brave-core#2107

Comments

@tildelowengrimm
Copy link
Contributor

tildelowengrimm commented Mar 20, 2019

Test plan

  1. Launch nightly channel browser and open settings page.
  2. Check Make default button is visible in Default browser section
  3. Click that button and check nightly brave is registered as a default by reloading settings page again.

Description

Just installed version 0.64.7 Chromium: 73.0.3683.75 (Official Build) nightly (64-bit)
Screen Shot 2019-03-20 at 14 38 03

Reader, I was able to set Brave as my default browser manually. Looks fine on Dev, but not nightly.

@tildelowengrimm tildelowengrimm added the feature/global-settings Settings at browser level independent of shields settings label Mar 20, 2019
@rebron
Copy link
Collaborator

rebron commented Mar 22, 2019

cc: @simonhong

@btlechowski
Copy link

btlechowski commented Apr 25, 2019

Verification passed on

Brave 0.64.60 Chromium: 74.0.3729.91 (Official Build) beta (64-bit)
Revision 03844ed83e02b8add3f4b9cb859a7108d55b2e4d-refs/branch-heads/3729@{#860}
OS Windows 10 OS Build 17134.523

Used test plan from the description.

Verified passed with

Brave 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
Brave 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
Brave 0.65.85 Chromium: 74.0.3729.131 (Official Build) dev(64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
Brave 0.66.50 Chromium: 74.0.3729.131 (Official Build)nightly (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Mac OS X
  • Verified STR from description for each channel: Release, Beta, Dev, Nightly. Was able to make each channel the default browser from brave://settings for versions specified above.

Verification passed on

Brave 0.67.2 Chromium: 74.0.3729.131 (Official Build) nightly (64-bit) 0.66.58 Chromium: 74.0.3729.131 (Official Build) dev (64-bit) 0.64.72 Chromium: 74.0.3729.131 (Official Build) beta (64-bit) 0.63.55 Chromium: 74.0.3729.131 (Official Build) (64-bit)
Revision 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954} 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954} 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954} 518a41c1fa7ce1c8bb5e22346e82e42b4d76a96f-refs/branch-heads/3729@{#954}
OS Linux Linux Linux Linux
  • All branch set its version as default as expected

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants