Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update shields onboarding tooltip #38237

Closed
rebron opened this issue May 10, 2024 · 4 comments · Fixed by brave/brave-core#23627
Closed

Update shields onboarding tooltip #38237

rebron opened this issue May 10, 2024 · 4 comments · Fixed by brave/brave-core#23627
Assignees
@simonhong
Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Milestone
1.66.x - Release

Comments

@rebron
Copy link
Collaborator

rebron commented May 10, 2024

Description

Update the tooltip for Shields during onboarding to match Android/iOS.

Miscellaneous Information:
@simonhong simonhong self-assigned this May 14, 2024
simonhong added a commit to brave/brave-core that referenced this issue May 14, 2024
@simonhong
Updated brave help bubble UI
72b7392 
fix brave/brave-browser#38237
@simonhong simonhong mentioned this issue May 14, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 14, 2024
This was referenced May 14, 2024
Merged
Merged
@rebron rebron added the onboarding Front-end related to helping a new user learn about features within the browser. label May 14, 2024
@kjozwiak kjozwiak added this to Completed in Front End May 14, 2024
@kjozwiak
Copy link
Member

The above requires 1.66.108 or higher for 1.66.x verification 👍

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented May 15, 2024 •
edited

Verification PASSED on

Brave | 1.66.108 Chromium: 125.0.6422.41 (Official Build) (64-bit)
-- | --
Revision | 3a79189ba4e3cf17c382dd265d4f447f83a8f49d
OS | Windows 10 Version 22H2 (Build 19045.4291)

Verified that Brave Shields tooltip is updated and working as expected

@MadhaviSeelam MadhaviSeelam added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 15, 2024
@stephendonner
Copy link

Verified PASSED using

Brave | 1.66.108 Chromium: 125.0.6422.41 (Official Build) (x86_64)
-- | --
Revision | 3a79189ba4e3cf17c382dd265d4f447f83a8f49d
OS | macOS Version 11.7.10 (Build 20G1427)

Confirmed that Brave Shields' tooltip is updated and working/displaying as expected.

@MadhaviSeelam
Copy link

Verification PASSED using

Brave	1.66.108 Chromium: 125.0.6422.41 (Official Build) (64-bit) 
Revision	3a79189ba4e3cf17c382dd265d4f447f83a8f49d
OS	Linux

Confirmed that Brave Shields' tooltip is updated and working/displaying as expected.

@MadhaviSeelam MadhaviSeelam added QA Pass-Linux and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 15, 2024
@rebron rebron removed this from Completed in Front End May 16, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@simonhong simonhong

Labels
onboarding Front-end related to helping a new user learn about features within the browser. OS/Desktop QA Pass-Linux QA Pass-macOS QA Pass-Win64 QA/Test-All-Platforms QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release
Development

Successfully merging a pull request may close this issue.

Updated brave help bubble UI brave/brave-core
8 participants
@fmarier @stephendonner @kjozwiak @rebron @simonhong @GeetaSarvadnya @brave-builds @MadhaviSeelam