Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add 1.66 translations #38342

Closed
Tracked by #38470
iccub opened this issue May 15, 2024 · 2 comments · Fixed by brave/brave-core#23693
Closed
Tracked by #38470

Add 1.66 translations #38342

iccub opened this issue May 15, 2024 · 2 comments · Fixed by brave/brave-core#23693
Labels
l10n OS/iOS Fixes related to iOS browser functionality QA Pass-iPhone QA/Yes release-notes/exclude
Milestone
1.66.x - Release #2

Comments

@iccub
Copy link

iccub commented May 15, 2024

No description provided.

@iccub iccub added OS/iOS Fixes related to iOS browser functionality QA/Yes release-notes/exclude labels May 15, 2024
iccub added a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations.
4370ea2 
brave/brave-browser#38342
@iccub iccub mentioned this issue May 16, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations.
c926c66 
brave/brave-browser#38342
@iccub iccub mentioned this issue May 16, 2024
Closed
24 tasks
iccub added a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations.
4b35415 
brave/brave-browser#38342
@iccub iccub mentioned this issue May 16, 2024
Merged
24 tasks
iccub added a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations.
b90fbbf 
brave/brave-browser#38342
@iccub iccub mentioned this issue May 16, 2024
Merged
24 tasks
kjozwiak pushed a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations. (downlift to 1.67.x) (#23692)
8b8fe99 
* add

* [iOS] Add 1.66.x translations.

brave/brave-browser#38342
@brave-builds brave-builds added this to the 1.67.x - Beta milestone May 16, 2024
kjozwiak pushed a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
[iOS] Add 1.66.x translations. (#23690)
7f0d105 
* [iOS] Add 1.66.x translations.

brave/brave-browser#38342

* Review.
@kjozwiak kjozwiak added the l10n label May 16, 2024
@kjozwiak
Copy link
Member

The above requires 1.66.111 or higher for 1.66.x verification 👍

kjozwiak pushed a commit to brave/brave-core that referenced this issue May 16, 2024
@iccub
Add 1.66.x translations. (downlift to 1.68.x) (#23693)
9e510b8 
* add

* [iOS] Add 1.66.x translations.

brave/brave-browser#38342
@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label May 21, 2024
@Uni-verse Uni-verse mentioned this issue May 21, 2024
Closed
2 tasks
@hffvld
Copy link
Contributor

hffvld commented May 22, 2024 •
edited

Verified on iPhone 14 using version(s):

Device/OS: iPhone 14 / iOS 17.5
Brave build: 1.66 (112)
BraveCore: 1.66.112 (125.0.6422.60)

STEPS:

  1. Install Brave 1.66.112 or newer
  2. Go to device Settings
  3. Change device language
  4. Go to Passwords > Set Brave as a password manager > Verify
  5. Go to Brave
  6. Open www.feedly.com (or any other website that requires a sign in)
  7. Sign in with your credentials > Observe the bottom sheet pop-up
  8. Save password > Verify
  9. Sign out and sign in again > Verify

ACTUAL RESULTS:

  • Verified translation of Brave Autofill provider into different languages like Russian, French, Japanese and Dutch
Russian French
1 2
1 2
1 2
1 2
1 2
1 2
1 2
1 2
Japanese Dutch
1 2
1 2
1 2
1 2
1 2
1 2
1 2
1 2

@hffvld hffvld added QA Pass-iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
l10n OS/iOS Fixes related to iOS browser functionality QA Pass-iPhone QA/Yes release-notes/exclude
Projects
None yet
Milestone
1.66.x - Release #2
Development

Successfully merging a pull request may close this issue.

Add 1.66.x translations. (downlift to 1.68.x) brave/brave-core
4 participants
@kjozwiak @iccub @brave-builds @hffvld