Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab #38444

Closed
Tracked by #28873
sangwoo108 opened this issue May 21, 2024 · 2 comments · Fixed by brave/brave-core#23755
Closed
Tracked by #28873

Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab #38444

sangwoo108 opened this issue May 21, 2024 · 2 comments · Fixed by brave/brave-core#23755
Assignees
@sangwoo108
Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Milestone
1.68.x - Beta

Comments

@sangwoo108
Copy link

sangwoo108 commented May 21, 2024 •
edited
Loading

Currently, dummy contents doesn't render anything. So instead of leave it blank, we should show an interstitial page that explains what's going on.
@sangwoo108 sangwoo108 mentioned this issue May 21, 2024
Closed
@sangwoo108 sangwoo108 changed the title Show an interstitial / WebUI / Views page with an image representation of the actual WebContents Show an interstitial page with an image representation of the actual WebContents May 21, 2024
@sangwoo108 sangwoo108 changed the title Show an interstitial page with an image representation of the actual WebContents Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab May 21, 2024
@sangwoo108 sangwoo108 self-assigned this May 21, 2024
@sangwoo108 sangwoo108 added priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude OS/Desktop feature/pinned-tabs labels May 21, 2024
@sangwoo108 sangwoo108 mentioned this issue May 21, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 22, 2024
@TEMP-ad
Copy link

TEMP-ad commented May 23, 2024

This is causing any tab pinned or unpinned to get the interstitial message.

1.68.36 Chromium: 125.0.6422.76 (Official Build) nightly (64-bit) Windows 11 Version 23H2 (Build 22631.3593)

How to reproduce:

  1. just have some tabs opened
  2. pin some
  3. open a new window
  4. click on the pinned tabs in the new window.
  5. see how the active tab in the original window gets the message about the tab being shared
  6. the only way is to go to the original window and change tabs, if you click on the interstitial message nothing will happen, it will only switch between pinned tabs if you are on the correct pinned tab.
Recording.2024-05-22.182016.mp4

@sangwoo108
Copy link
Author

sangwoo108 commented May 23, 2024 •
edited
Loading

Hi @TEMP-ad ! Thanks for reporting. That might be only happening on Windows. It should be replaced as soon as the window is activated. Let me take a look asap.

I was wrong. We shouldn't install the interstitial page when the shared pinned tab is not the active tab.

This was referenced May 23, 2024
Merged
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@sangwoo108 sangwoo108

Labels
feature/pinned-tabs OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA/No release-notes/exclude
Projects
None yet
Milestone
1.68.x - Beta
Development

Successfully merging a pull request may close this issue.

Show interstitial page when dummy tab is active brave/brave-core
3 participants
@sangwoo108 @brave-builds @TEMP-ad