Follow-ups for shared pinned tabs(a.k.a. Persistent pinned tabs)

[sangwoo108]

Follow-ups after #28532

Tasks

Beta Give feedback

1. [Shared pinned tab] Don't close the pinned tab with cmd-w. #37125
   OS/Desktop QA/No priority/P4 release-notes/exclude +4
   
2. Shared Pinned Tabs: popups don't auto-close #29865
   OS/Desktop bug closed/stale feature/pinned-tabs release-notes/exclude +5
   
3. I unpinned all of my pinned tabs - and when the last one was unpinned, it crashes the browser - https://brave.sp.backtrace.io/p/brave/debug?filters=(_deleted=0,_rxid="63320000-69c0-e309-0000-000000000000")&fingerprint=16f71aa104092914f4bb92a3c9e25f980c225ceae58c8d9512218da4e4a7fdb2&debug=("49628a4",0,0) - not reproducible
4. "Bring all tabs to this window" with shared pinned tab causes crash #37925
   OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
   
5. Don't show about:blank in the LocationBar for inactive pinned tabs in the background #38255
   OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
   
6. Closing a window with active shared pinned tab removes shared WebContents from other windows too - irreproducible
7. Shared pinned tab may not work after Chromium 125 #37973
   OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
   
8. close windows when all non-pinned tabs are closed, with shared pinned tabs enabled #38414
   OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
   
9. When closing a tab, if it's the last in the window, and there's another window, then close the window. i.e. ignore that there are pinned tabs in the window and don't prevent it closing as normal
10. Show an interstitial page with an image representation of the actual WebContents for Dummy contents of Shared Pinned tab #38444
    OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
    
11. Crash when creating new window with Shared pinned tab enabled #38472
    OS/Desktop OS/macOS QA/No crash feature/pinned-tabs release-notes/exclude +6
    
12. Preference to use shared pinned tabs (possibly) #38509
    OS/Desktop QA/No feature/pinned-tabs priority/P3 release-notes/exclude +5
    
13. Restart browser and restore tabs results in duplicate shared pinned tabs, (https://bravesoftware.slack.com/archives/C042KL922P3/p1680714966162409) - this would be expected behavior

[rishiraj88]

Thanks, @sangwoo108 , for this.

[ajayseeker]

Hi @sangwoo108,
I would like to work on the following task
"Don't close the pinned tab with cmd-w. Instead ignore it, or close the WebContents instance but leave the site pinned."
Do we still need this behaviour?
Also, I checked other browsers like Chrome, they don't support this. But yes thinking logically, it's a good idea to either not close or ask for confirmation from user when he presses Cmd + w.

[sangwoo108]

Hi @ajayseeker , the behavior is only when the shared pinned tab is enabled. That's because we don't want shared pinned tab to be closed accidentally. If you think we should reconsider it, we always have a room for discussion

Please refer to brave/brave-core#17295 (review)

[ajayseeker]

Hi @ajayseeker , the behavior is only when the shared pinned tab is enabled. That's because we don't want shared pinned tab to be closed accidentally. If you think we should reconsider it, we always have a room for discussion

Please refer to brave/brave-core#17295 (review)

I think this behaviour is good to have!
I would like to work on this. Can you please assign me this item?
Subsequently, I would like to explore other tasks mentioned in this issue too.

[sangwoo108]

@ajayseeker I really appreciate that. I created issue here #37125

[sangwoo108]

Hi everyone, as of brave/brave-core#23797 , we'll introduce preference for Shared pinned tab under settings > appearance > tabs. The flag will only reveal the preference but not enable the preference. Please turn on the pref if you want to keep using it.

[ghost]

when you have a window with a pinned tab and a normal tab, and then you move the non-pinned tab, sometimes (often) it leaves behind a bunch of non visible windows. They disappear when Show pinned tabs in all windows is turned off.

From this screenshot I only had 1 window opened and it showed all of those invisible windows to send tabs to.

Also, drag and dropping a normal tab and attach it to other windows from one monitor to another, especially trying to attach it 'back' to its previous window, seem to cause the tab to be blank/dark, if it is a video, you can still hear it but no visible content, you open Devtools everything is fine, but it will stay like that until you turn Show pinned tabs in all windows off and on, or duplicate the tab and close the one. I could easily reproduce it 100% when using multiple monitors, don't think I saw this happening in the same monitor.

1.68.61 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
Windows 11 Version 23H2 (Build 22631.3672)