Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

The question bubbles resulting from clicking on Suggest questions... are incorrectly aligned #38508

Closed
2 of 6 tasks
stephendonner opened this issue May 22, 2024 · 6 comments · Fixed by brave/brave-core#23943
Closed
2 of 6 tasks

Comments

@stephendonner
Copy link

Description

The question bubbles resulting from clicking on Suggest questions... are incorrectly aligned

Steps to reproduce

  1. install 1.68.36
  2. launch Brave
  3. click on Leo in the sidebar
  4. opt-in by clicking I understand
  5. load any page
  6. click on Summarize this page
  7. click on Suggest questions...
  8. look at the alignment of the resulting Suggest questions...' button

Actual result

beta (good) vs. nightly (bad)

Screenshot 2024-05-22 at 2 23 42 PM

Expected result

See above; the Suggest questions' bubbles should be more flush/centered with the answer/conversation above it

Reproduces how often

Easily reproduced

Brave version (brave://version info)

Brave | 1.68.36 Chromium: 125.0.6422.76 (Official Build) nightly (arm64)
-- | --
Revision | e4a82b7ddcc233e5ae0d1ca0af8338fa6be79b6a
OS | macOS Version 13.6.4 (Build 22G513)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

cc @nullhook @bbondy @petemill @mattmcalister @rebron @brave/qa-team

@stephendonner
Copy link
Author

(Actually, on closer inspection, perhaps its also/primarily the positioning of the bulleted list above them, too?)

@stephendonner
Copy link
Author

cc @aguscruiz

@aguscruiz
Copy link

aguscruiz commented May 23, 2024

Already had a duplicate here :D
#38504

I'll carry over the info to this comment

At some point, the size of the suggested questions buttons got really big. They're supposed to be smaller

Design here:
https://www.figma.com/design/m0Gdbf0wtqyfEFGm32VLLc/Leo?node-id=347%3A19541&t=NPZh7807Ys9EjbnC-1

Actual result

image

Expected result

image

@mattmcalister mattmcalister added the priority/P3 The next thing for us to work on. It'll ride the trains. label May 23, 2024
@aguscruiz
Copy link

aguscruiz commented May 31, 2024

There's also been a padding adjustment on the button to make it smaller and fit the design.

@LaurenWags
Copy link
Member

@nullhook @rebron can one of you add the following labels as necessary:

  • release-notes/exclude or release-notes/include

@stephendonner
Copy link
Author

Verification PASSED using

Brave | 1.68.85 Chromium: 126.0.6478.40 (Official Build) beta (64-bit)
-- | --
Revision | 8e76a669cf78bdfa933c8d569460092a01166588
OS | Windows 10 Version 22H2 (Build 19045.4474)

Steps to reproduce:

  1. installed 1.68.85
  2. launch Brave
  3. click on Leo in the sidebar
  4. opt-in by clicking I understand
  5. load any page
  6. click on Summarize this page
  7. click on Suggest questions...
  8. look at the alignment of the resulting `Suggest questions...' button

Confirmed correct alignment of the Suggest questions... buttons

example example example
image image image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Done
Development

Successfully merging a pull request may close this issue.

5 participants