Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

aichat: fixed a11y issues for slash tools and mic button #23942

Merged
merged 2 commits into from
Jun 1, 2024
Merged

Conversation

nullhook
Copy link
Contributor

@nullhook nullhook commented May 31, 2024

Resolves brave/brave-browser#38747

Submitter Checklist:

  • I confirm that no security/privacy review is needed and no other type of reviews are needed, or that I have requested them
  • There is a ticket for my issue
  • Used Github auto-closing keywords in the PR description above
  • Wrote a good PR/commit description
  • Squashed any review feedback or "fixup" commits before merge, so that history is a record of what happened in the repo, not your PR
  • Added appropriate labels (QA/Yes or QA/No; release-notes/include or release-notes/exclude; OS/...) to the associated issue
  • Checked the PR locally:
    • npm run test -- brave_browser_tests, npm run test -- brave_unit_tests wiki
    • npm run presubmit wiki, npm run gn_check, npm run tslint
  • Ran git rebase master (if needed)

Reviewer Checklist:

  • A security review is not needed, or a link to one is included in the PR description
  • New files have MPL-2.0 license header
  • Adequate test coverage exists to prevent regressions
  • Major classes, functions and non-trivial code blocks are well-commented
  • Changes in component dependencies are properly reflected in gn
  • Code follows the style guide
  • Test plan is specified in PR before merging

After-merge Checklist:

Test Plan:

@nullhook nullhook requested a review from a team as a code owner May 31, 2024 18:54
@github-actions github-actions bot added the CI/storybook-url Deploy storybook and provide a unique URL for each build label May 31, 2024
@nullhook nullhook requested a review from petemill May 31, 2024 19:03
@nullhook nullhook changed the title aichat: fixed a11y and spacing issues aichat: fixed a11y issues for slash tools and mic button May 31, 2024
@brave-builds
Copy link
Collaborator

A Storybook has been deployed to preview UI for the latest push

Copy link
Member

@petemill petemill left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

image

@nullhook nullhook merged commit 641ec36 into master Jun 1, 2024
19 checks passed
@nullhook nullhook deleted the ui-updates branch June 1, 2024 00:58
@github-actions github-actions bot added this to the 1.68.x - Nightly milestone Jun 1, 2024
brave-builds added a commit that referenced this pull request Jun 1, 2024
nullhook pushed a commit that referenced this pull request Jun 3, 2024
@stephendonner
Copy link
Collaborator

stephendonner commented Jun 3, 2024

Verified PASSED using

Brave | 1.68.69 Chromium: 126.0.6478.26 (Official Build) nightly (64-bit)
-- | --
Revision | 324d56faeb38b1ac6ace22c6c7dbddfb77f3f737
OS | Windows 10 Version 22H2 (Build 19045.4474)

Steps:

  1. installed 1.68.69
  2. launched Brave
  3. opted-in to Leo
  4. hovered over the `[ / ] menu

Confirmed tooltip of Leo Tools (shouldn't it be Leo AI Tools?

Confirmed proper spacing in slash-tools menu of Change tone / Expand (was previously Change tone/ Expand

image

kjozwiak pushed a commit that referenced this pull request Jun 3, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
CI/storybook-url Deploy storybook and provide a unique URL for each build
Projects
Status: Done
4 participants