Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Android] Fix domain representation in Shields pop-up #38514

Closed
deeppandya opened this issue May 23, 2024 · 2 comments · Fixed by brave/brave-core#23927
Closed

[Android] Fix domain representation in Shields pop-up #38514

deeppandya opened this issue May 23, 2024 · 2 comments · Fixed by brave/brave-core#23927
Assignees
@deeppandya
Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security
Milestone
1.67.x - Release

Comments

@deeppandya
Copy link

More info: https://hackerone.com/reports/2501378
@deeppandya deeppandya added QA/Yes release-notes/include OS/Android Fixes related to Android browser functionality labels May 23, 2024
@deeppandya deeppandya self-assigned this May 23, 2024
@deeppandya deeppandya mentioned this issue May 23, 2024
Closed
@deeppandya deeppandya added priority/P2 A bad problem. We might uplift this to the next planned release. security labels May 23, 2024
@deeppandya deeppandya mentioned this issue May 31, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone May 31, 2024
@brave-builds brave-builds mentioned this issue May 31, 2024
Merged
7 tasks
@kjozwiak
Copy link
Member

kjozwiak commented Jun 4, 2024

The above requires 1.67.105 or higher for 1.67.x verification 👍

@hffvld hffvld added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 5, 2024
@hffvld
Copy link
Contributor

hffvld commented Jun 6, 2024 •
edited

Verified on Galaxy Tab S8 and Pixel 7 using version(s):

Device/OS: 
- Galaxy Tab S8 / gts8wifixx-user 14 UP1A.231005.007 release-keys
- Pixel 7 / panther_beta-user 14 AP31.240426.023.B4 release-keys
Brave build: 1.67.105
Chromium: 126.0.6478.26 (Official Build) beta (64-bit)

STEPS:

  1. Follow the STR/TP from Update ellipsize from end to start brave-core#23927 (comment)
  2. Verify

ACTUAL RESULTS:

  • Verified that the Shields displays the end of the URL/Domain
Galaxy Tab S8
Reproduced in 1.66.120 Verified in 1.67.105
1 2
1 2
Pixel 7
Reproduced in 1.66.120 Verified in 1.67.105
1 2
1 2

@hffvld hffvld added QA Pass - Android ARM QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 6, 2024
@kjozwiak kjozwiak mentioned this issue Jun 14, 2024
Closed
@hffvld hffvld mentioned this issue Jun 14, 2024
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@deeppandya deeppandya

Labels
OS/Android Fixes related to Android browser functionality priority/P2 A bad problem. We might uplift this to the next planned release. QA Pass - Android ARM QA Pass - Android Tab QA/Test-All-Platforms QA/Yes release-notes/include security
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging a pull request may close this issue.

Update ellipsize from end to start brave/brave-core
4 participants
@kjozwiak @deeppandya @brave-builds @hffvld