Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update ellipsize from end to start (uplift to 1.67.x) #23939

Merged
merged 1 commit into from
Jun 4, 2024
Merged

Update ellipsize from end to start (uplift to 1.67.x) #23939

merged 1 commit into from
Jun 4, 2024

Conversation

brave-builds
Copy link
Collaborator

@brave-builds brave-builds commented May 31, 2024 •
edited by kjozwiak
Loading

Uplift of #23927
Resolves brave/brave-browser#38514

Pre-approval checklist:

  • You have tested your change on Nightly.
  • This contains text which needs to be translated.
    • There are more than 7 days before the release.
    • I've notified folks in #l10n on Slack that translations are needed.
  • The PR milestones match the branch they are landing to.

Pre-merge checklist:

  • You have checked CI and the builds, lint, and tests all pass or are not related to your PR.

Post-merge checklist:

  • The associated issue milestone is set to the smallest version that the changes is landed on.

@brave-builds brave-builds requested a review from a team as a code owner May 31, 2024 17:08
@brave-builds brave-builds requested a review from a team May 31, 2024 17:08
@brave-builds brave-builds added this to the 1.67.x - Beta milestone May 31, 2024
@brave-builds brave-builds self-assigned this May 31, 2024
@deeppandya deeppandya force-pushed the pr23927_resolve_shields_url_ellip_android_1.67.x branch from b4ae466 to 3e2e066 Compare June 3, 2024 16:52
kjozwiak
kjozwiak approved these changes Jun 4, 2024
View reviewed changes
Copy link
Member

@kjozwiak kjozwiak left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Uplift into 1.67.x approved 👍 QA has verified the PR on Nightly using 1.68.x as per #23927 (comment).

@kjozwiak kjozwiak merged commit 569f5a6 into 1.67.x Jun 4, 2024
14 checks passed
@kjozwiak kjozwiak deleted the pr23927_resolve_shields_url_ellip_android_1.67.x branch June 4, 2024 02:35
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@kjozwiak kjozwiak kjozwiak approved these changes

Assignees

@brave-builds brave-builds

Labels
None yet
Projects
None yet
Milestone
1.67.x - Release
Development

Successfully merging this pull request may close these issues.
2 participants
@brave-builds @kjozwiak