Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[iOS] - Sometimes Playlist Items save offline but won't delete #38665

Closed
1 of 5 tasks
Brandon-T opened this issue May 29, 2024 · 5 comments · Fixed by brave/brave-core#23891
Closed
1 of 5 tasks

[iOS] - Sometimes Playlist Items save offline but won't delete #38665

Brandon-T opened this issue May 29, 2024 · 5 comments · Fixed by brave/brave-core#23891

Comments

@Brandon-T
Copy link

Description

Steps to reproduce

  1. No idea!

Actual result

Cannot reproduce it ever

Expected result

Cannot Reproduce the issue

Reproduces how often

No steps to reproduce

Brave version

1.6xx

Device/iOS version

iPhone

Affected browser versions

  • latest AppStore
  • latest TestFlight
  • previous TestFlight

Reproducibility

  • with Brave Shields disabled
  • in the latest version of mobile Safari

Miscellaneous information

No response

@kjozwiak
Copy link
Member

kjozwiak commented Jun 5, 2024

The above requires 1.66.120 or higher for 1.66.x verification 👍 @Uni-verse @hffvld as per the above, there's no specific STR/Cases that we can check to ensure that the issue has been resolved. So for the above, lets just run through a quick regression check and ensure that adding/removing items from the Playlist is working without any issues. Unless someone reproduces the issue on an older build and can verify the above.

@Uni-verse Uni-verse added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jun 6, 2024
@Uni-verse
Copy link
Contributor

Uni-verse commented Jun 6, 2024

Verified on iPhone 12 Pro running iOS 17.3.1 using version 1.66.1 (120)

  • Ensured that items in Playlist can be deleted whether saved offline or not.
  • Ensured that folders can be deleted.
  • Ensured that items are deleted when swiping and also in edit mode.
  • Ensured items can be deleted completely after adding to playlist from various video sites for existing users.
Example Example Example
IMG_6308 IMG_6309 IMG_6310
Example Example Example
IMG_6312 IMG_6313 IMG_6314

@Uni-verse Uni-verse added QA Pass - iPhone and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jun 6, 2024
@iccub iccub reopened this Jun 18, 2024
@iccub
Copy link

iccub commented Jun 18, 2024

Reopened. Please retest once we find a fix. We will add a debug menu to test performance as well

@Uni-verse
Copy link
Contributor

Verification for 1.66.2 was done here #39146 (comment) on iPhone.

@kjozwiak kjozwiak added this to the 1.66.x - Release #6 milestone Jun 22, 2024
@kjozwiak
Copy link
Member

@iccub we don't re-open issues once they have an associated PR as per the process. In this case, this already went out as well even though it was eventually reverted. It gets too hard to follow when an issue is technically in several milestones and has several different PRs associated with it. For example, in this case, we know need to remove it from the 1.66.x - Release #6 milestone even though this was part of the official release.

Created a follow up via #39286.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

5 participants