Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Enable Web Serial by default #38791

Closed
4 of 6 tasks
ShivanKaul opened this issue Jun 4, 2024 · 3 comments · Fixed by brave/brave-core#24258
Closed
4 of 6 tasks

Enable Web Serial by default #38791

ShivanKaul opened this issue Jun 4, 2024 · 3 comments · Fixed by brave/brave-core#24258

Comments

@ShivanKaul
Copy link
Collaborator

Description

We currently disable Web Serial by default, and allow enabling via flag. On looking at the user flow now, I don't see a reason to keep this disabled. Users get a permission popup and the API doesn't increase fingerprinting surface by default. Mozilla also changed their position recently; in Chromium Web Serial use requires a permission popup.

image

Steps to reproduce

Check status of brave://flags/#brave-web-serial-api

Actual result

Is off by default

Expected result

Should be on by default

Reproduces how often

Easily reproduced

Brave version (brave://version info)

1.68.40 Chromium: 125.0.6422.76 (Official Build) nightly (arm64) (I'm on Nightly but this is on all versions)

Channel information

  • release (stable)
  • beta
  • nightly

Reproducibility

  • with Brave Shields disabled
  • with Brave Rewards disabled
  • in the latest version of Chrome

Miscellaneous information

No response

@mkarolin
Copy link
Contributor

Test plan:

  1. Start Brave and navigate to permissions.site
  2. Click on Serial button

Observe:
Permission prompt shows up.

  1. Cancel from the permission prompt
  2. Navigate to brave://settings/content
  3. Click Additional permissions
  4. Verify that Serial ports is listed

@mkarolin
Copy link
Contributor

Note on deviation from the original description. Instead of making the flag enabled by default, the flag was removed entirely.

@stephendonner
Copy link

Verified PASSED using

Brave | 1.69.53 Chromium: 127.0.6533.17 (Official Build) nightly (x86_64)
-- | --
Revision | bedcc2e74ce45bd641d2946e0d870d68ba08b8e9
OS | macOS Version 11.7.10 (Build 20G1427)

Steps:

  1. installed 1.69.53
  2. launched Brave
  3. opened brave://flags
  4. searched for serial
  5. confirmed no matching flags
  6. loaded permission.site
  7. clicked on Serial
  8. confirmed permissions prompt
  9. clicked on Connect for the first highlighted entry
  10. confirmed the Serial button on the page turned green (enabled)
  11. clicked again on Serial

Confirmed Web Serial was enabled by default, has no flag, and I could successfully pair

example example example example
Screen Shot 2024-06-26 at 12 05 51 PM Screen Shot 2024-06-26 at 12 05 59 PM Screen Shot 2024-06-26 at 12 06 08 PM Screen Shot 2024-06-26 at 12 06 14 PM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
Status: Completed
Development

Successfully merging a pull request may close this issue.

3 participants