Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[ads] Notification ads should not be served if multiple media players are playing #38820

Closed
tmancey opened this issue Jun 5, 2024 · 2 comments · Fixed by brave/brave-core#24013
Closed

[ads] Notification ads should not be served if multiple media players are playing #38820

tmancey opened this issue Jun 5, 2024 · 2 comments · Fixed by brave/brave-core#24013
Assignees
@tmancey
Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Milestone
1.68.x - Release

Comments

@tmancey
Copy link
Contributor

tmancey commented Jun 5, 2024 •
edited
Loading

No description provided.

@tmancey tmancey added enhancement priority/P3 The next thing for us to work on. It'll ride the trains. QA/Yes release-notes/exclude feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop labels Jun 5, 2024
@tmancey tmancey self-assigned this Jun 5, 2024
@tmancey tmancey changed the title [ads] Serve notification ads if media is playing but audio is muted [ads] Notification ads should not be served if multiple media players are playing Jun 5, 2024
@tmancey tmancey added bug and removed enhancement labels Jun 5, 2024
@tmancey tmancey mentioned this issue Jun 5, 2024
Merged
24 tasks
@brave-builds brave-builds added this to the 1.68.x - Nightly milestone Jun 6, 2024
@btlechowski
Copy link

Verified with

Verified test plan from brave/brave-core#24013

One media playing

started

[3438:3438:0622/111435.384099:VERBOSE2:tab_manager.cc(186)] Tab id 1824605484 started playing media

stopped

[3438:3438:0622/111451.375828:VERBOSE2:tab_manager.cc(198)] Tab id 1824605484 stopped playing media

Two media playing

1st started

[4234:4234:0622/112229.751184:VERBOSE2:tab_manager.cc(186)] Tab id 1824605550 started playing media

2nd started

[4234:4234:0622/112311.722864:VERBOSE2:tab_manager.cc(186)] Tab id 1824605549 started playing media

1st stopped

[4234:4234:0622/112350.162495:VERBOSE2:tab_manager.cc(198)] Tab id 1824605550 stopped playing media

2nd stopped

[4234:4234:0622/112717.578379:VERBOSE2:tab_manager.cc(198)] Tab id 1824605549 stopped playing media

notification ads in active tab with media playing

Verified notification ads are not shown

[4234:4234:0622/112556.857398:VERBOSE2:permission_rules.cc(266)] Media is playing
[4234:4234:0622/112556.859592:VERBOSE1:notification_ad_serving.cc(78)] Notification ad not served: Not allowed due to permission rules

@btlechowski btlechowski added the QA/In-Progress Indicates that QA is currently in progress for that particular issue label Jul 15, 2024
@btlechowski
Copy link

btlechowski commented Jul 18, 2024 •
edited
Loading

Verified with 1.68.123 on Lenovo TB-8506FS (Android 11.0)

Verified test plan from brave/brave-core#24013

One media playing

started

19:14:46.889  V  [VERBOSE2:tab_manager.cc(186)] Tab id 1556316298 started playing media

stopped

19:15:25.515  V  [VERBOSE2:tab_manager.cc(198)] Tab id 1556316298 stopped playing media

Two media playing

1st started

19:19:06.008  V  [VERBOSE2:tab_manager.cc(186)] Tab id 1556316298 started playing media

2nd started

19:20:30.713  V  [VERBOSE2:tab_manager.cc(186)] Tab id 1556316300 started playing media

1st stopped automatically

19:20:30.734  V  [VERBOSE2:tab_manager.cc(198)] Tab id 1556316298 stopped playing media

2nd stopped

19:21:01.684  V  [VERBOSE2:tab_manager.cc(198)] Tab id 1556316300 stopped playing media

notification ads in active tab with media playing

Verified notification ads are not shown

19:38:11.866  V  [VERBOSE2:permission_rules.cc(266)] Media is playing
19:38:11.867  V  [VERBOSE1:notification_ad_serving.cc(78)] Notification ad not served: Not allowed due to permission rules

@btlechowski btlechowski added QA Pass - Android Tab and removed QA/In-Progress Indicates that QA is currently in progress for that particular issue labels Jul 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tmancey tmancey

Labels
bug feature/ads OS/Android Fixes related to Android browser functionality OS/Desktop priority/P3 The next thing for us to work on. It'll ride the trains. QA Pass - Android Tab QA Pass-Linux QA/Yes release-notes/exclude
Projects
Ads
Status: Done
Milestone
1.68.x - Release
3 participants
@tmancey @btlechowski @brave-builds