Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[Storybook]: Enable storyStoreV7 so we can upgrade to Storybook 8 #39145

Closed
2 tasks done
fallaciousreasoning opened this issue Jun 19, 2024 · 0 comments · Fixed by brave/brave-core#24275
Closed
2 tasks done

[Storybook]: Enable storyStoreV7 so we can upgrade to Storybook 8 #39145

fallaciousreasoning opened this issue Jun 19, 2024 · 0 comments · Fixed by brave/brave-core#24275
Assignees
@fallaciousreasoning
Labels
dependency/update dev/storybook dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Milestone
1.69.x - Release

Comments

@fallaciousreasoning
Copy link

Currently, our stories aren't in the CSF3 format required for storybook 8, so we need to migrate in order to upgrade.

  • Convert stories to new format
  • Add indexer for stories in /stories/ directories as storyStoreV7 doesn't natively support them
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@fallaciousreasoning fallaciousreasoning

Labels
dependency/update dev/storybook dev-concern feature/web3/wallet Integrating Ethereum+ wallet support OS/Desktop QA/No release-notes/exclude
Projects
None yet
Milestone
1.69.x - Release
Development

Successfully merging a pull request may close this issue.

[Storybook]: Enable storyStoreV7 brave/brave-core
3 participants
@rebron @fallaciousreasoning @brave-builds