Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Ad Notification has a settings button in Gnome #4231

Closed
NickAnEngineer opened this issue Apr 25, 2019 · 4 comments · Fixed by brave/brave-core#2570
Closed

Ad Notification has a settings button in Gnome #4231

NickAnEngineer opened this issue Apr 25, 2019 · 4 comments · Fixed by brave/brave-core#2570
Assignees
@cg505
Labels
bug design A design change, especially one which needs input from the design team feature/ads feature/rewards good first issue OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Milestone
0.68.x - Release

Comments

@NickAnEngineer
Copy link

Description

When an ad notification pop up appears in Gnome it has a settings button in the notification that takes you to the ad site, exactly the same as clicking just the notification does. Don't know if the notification is meant to have a button but its misleading that its labelled 'Settings' and just takes you to the ad, was expecting to go the brave://rewards page or something. I think the button either needs removing, relabelling, or its action changing

Steps to Reproduce

  1. Enable ads
  2. Wait for a notification
  3. Click the button

Actual result:

Screenshot from 2019-04-25 11-03-00

Expected result:

Button actually goes to ad settings

Reproduces how often:

All add notifications - easily reproduced

Brave version (brave://version info)

Brave | 0.63.48 Chromium: 74.0.3729.108 (Official Build)unknown (64-bit)
Revision | daaff52abef89988bf2a26091062160b1482b108-refs/branch-heads/3729@{#901}
OS | Linux

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

Manjaro Linux with Gnome 3.32.1
@srirambv srirambv added design A design change, especially one which needs input from the design team feature/ads feature/rewards OS/Linux labels Apr 25, 2019
@srirambv srirambv added this to Untriaged Backlog in Rewards via automation Apr 25, 2019
@srirambv
Copy link
Contributor

Ideally it should open the system notification settings to turn on/off.

@kojid0
Copy link

kojid0 commented Apr 26, 2019

Facing the same issue (using ZorinOS) and the ad also does not go away automatically, as it does in windows after ~5 sec.

@srirambv
Copy link
Contributor

@jwsp1 ads notification persist for a longer duration this is expected behaviour

@NejcZdovc NejcZdovc added the priority/P5 Not scheduled. Don't anticipate work on this any time soon. label May 27, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Icebox in Rewards May 27, 2019
@cg505 cg505 self-assigned this May 31, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jun 1, 2019
@cg505
patch linux notifications to remove settings button
be28a14 
afcc62c did this for mac, but the
issue was never fixed on linux.

Fixes brave/brave-browser#4231.
@cg505 cg505 mentioned this issue Jun 1, 2019
Merged
29 tasks
cg505 added a commit to brave/brave-core that referenced this issue Jun 4, 2019
@cg505
patch linux notifications to remove settings button
a49d113 
afcc62c did this for mac, but the
issue was never fixed on linux.

Fixes brave/brave-browser#4231.
@cg505 cg505 added this to the 0.68.x - Nightly milestone Jun 4, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jun 4, 2019
@cg505
patch linux notifications to remove settings button
af70a84 
afcc62c did this for mac, but the
issue was never fixed on linux.

Fixes brave/brave-browser#4231.
@NejcZdovc NejcZdovc moved this from Icebox to Review/QA in Rewards Jun 10, 2019
cg505 added a commit to brave/brave-core that referenced this issue Jun 19, 2019
@cg505
patch linux notifications to remove settings button
18b565b 
afcc62c did this for mac, but the
issue was never fixed on linux.

Fixes brave/brave-browser#4231.
cg505 added a commit to brave/brave-core that referenced this issue Jun 20, 2019
@cg505
patch linux notifications to remove settings button
fa3f0b6 
afcc62c did this for mac, but the
issue was never fixed on linux.

Fixes brave/brave-browser#4231.
Rewards automation moved this from Review/QA to Done Jun 24, 2019
@kjozwiak kjozwiak mentioned this issue Aug 2, 2019
Closed
@btlechowski
Copy link

Verification passed on

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Verified test plan from brave/brave-core#2570
image

@LaurenWags LaurenWags mentioned this issue Aug 19, 2019
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@cg505 cg505

Labels
bug design A design change, especially one which needs input from the design team feature/ads feature/rewards good first issue OS/Linux priority/P5 Not scheduled. Don't anticipate work on this any time soon. QA Pass-Linux QA/Test-Plan-Specified QA/Yes release-notes/include
Projects
None yet
Milestone
0.68.x - Release
Development

Successfully merging a pull request may close this issue.

patch linux notifications to remove settings button brave/brave-core
8 participants
@NickAnEngineer @cg505 @kjozwiak @NejcZdovc @srirambv @kojid0 @LaurenWags @btlechowski