Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

URL.createObjectURL() incompatibility #4424

Closed
NathanaelA opened this issue May 14, 2019 · 3 comments · Fixed by brave/brave-core#2342
Closed

URL.createObjectURL() incompatibility #4424

NathanaelA opened this issue May 14, 2019 · 3 comments · Fixed by brave/brave-core#2342

Comments

@NathanaelA
Copy link

NathanaelA commented May 14, 2019

Test plan

See brave/brave-core#2342

Description

Docs: https://developer.mozilla.org/en-US/docs/Web/API/URL/createObjectURL

Steps to Reproduce

Using createObjectURL seems to create a state where Brave gets confused about things.
Basically the code generates a PDF in memory; and assigns it to an iFrame. Brave seems to be the only one affected and shows the following warning in the console.log:

Resource interpreted as Document but transferred with MIME type application/pdf: "blob:http://www.fluentreports.com/b4ffad1e-0f9e-4769-baf7-ea8cc21e454f".

Broken sites because of this:

  1. http://pdfkit.org/demo/browser.html
  2. http://www.fluentreports.com/demo.html

Actual result:

image

Expected result:

(From Chromium)
image

Reproduces how often:

Always

Brave version (brave://version info)

Windows (Should be current version)
Linux 0.63.48 Chromium: 74.0.3729.108 (Official Build) (64-bit)

Version/Channel Information:

Current Release (Been this way for a while, just haven't reported it)

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
    No.

  • Does the issue resolve itself when disabling Brave Rewards?
    Unknown

  • Is the issue reproducible on the latest version of Chrome?
    No, Chrome/Firefox/etc work great.

Miscellaneous Information:

The PDF blob source is being assigned to an iFrame.src property. (FluentReports is my site; so if you need any code to see, let me know)

@bsclifton
Copy link
Member

Confirmed this is fixed with brave/brave-core#2342 🎉

@rebron rebron added this to Untriaged Backlog in General May 28, 2019
@rebron rebron moved this from Untriaged Backlog to P4 Backlog in General May 28, 2019
@rebron rebron moved this from P4 Backlog to In progress in General May 28, 2019
@rebron rebron moved this from In progress to Pending review in General May 28, 2019
General automation moved this from Pending review to Completed May 31, 2019
@btlechowski
Copy link

btlechowski commented Jul 30, 2019

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Windows 7 Service Pack 1 (Build 7601.24494)

Verified test plan from brave/brave-core#2342
Verified test plan from the description.
image

Verification passed on

Brave 0.68.113 Chromium: 76.0.3809.62 (Official Build) beta (64-bit)
Revision 7b77856b3aa34d72f246d12340fc1ded8b2c0e83-refs/branch-heads/3809@{#798}
OS Linux
  • Verified PDF preview is generated on the link from issue description
    image

Verified passed with

Brave 0.68.114 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

@Naliniamu
Copy link

what is pipestream. is there anypackage for using pipe stream. how to send report as stream to browser

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment