Use pdfium #2342

simonhong · 2019-04-25T05:22:43Z

Fixes brave/brave-browser#3846
Fixes brave/brave-browser#3694
Fixes brave/brave-browser#884
Fixes brave/brave-browser#3119
Fixes brave/brave-browser#4424

To use pdfium, PluginRegistry::GetPlugins() must include pdfium plugins.
Built-in pdf plugins and flash are all that we can expose via navigator.plugins and mimeTypes.
So BravePluginRegistryImpl is deleted.

Submitter Checklist:

Test Plan:

Test fix for brave/brave-browser#3694

Go to https://docs.google.com and login
Create a new Google Sheets document
Type some values in there
Pick File => Print from the Google apps menu (not the browser menu)
Try to print document
Document should actually print (you should not be prompted to save as PDF)

Test fix for brave/brave-browser#884

Go to http://citeseerx.ist.psu.edu/viewdoc/download?doi=10.1.1.144.7135&rep=rep1&type=pdf
Document should load properly

Test fix for brave/brave-browser#4424

Go to http://pdfkit.org/demo/browser.html
Document on right hand side should load properly

Embed test (possible fix for brave/brave-browser#3119)

Go to https://pdfobject.com/examples/detection.html
Message This browser supports inline PDFs should be shown (green color)

Test that PDF.js is still installable

Go to https://chrome.google.com/webstore/detail/pdf-viewer/oemmndcbldboiebfnladdacbdfmadadm
Verify that you can install PDF.js
Verify that PDF.js puts a browser action button in the extension area
Verify that PDF.js shows in brave://extensions
Open a PDF document and verify PDF.js is used

Test that PDF.js does not show

Have an existing profile BEFORE testing this. Make sure PDF.js works
Upgrade to a build with this fix
Launch Brave from the command line with --show-component-extension-options
Verify PDF.js does not show in brave://extensions
Verify PDF.js does not show in brave://components

Reviewer Checklist:

New files have MPL-2.0 license header.
Request a security/privacy review as needed.
Adequate test coverage exists to prevent regressions
Verify test plan is specified in PR before merging to source

After-merge Checklist:

The associated issue milestone is set to the smallest version that the
changes has landed on.
All relevant documentation has been updated.

DEPS

jumde · 2019-04-25T17:05:36Z

chromium_src/third_party/blink/renderer/modules/plugins/navigator_pluginstest.cc

- * License, v. 2.0. If a copy of the MPL was not distributed with this file,
- * You can obtain one at http://mozilla.org/MPL/2.0/. */
-
-#include "base/path_service.h"


Are we planning to re-introduce navigator.plugins? I think updating the test makes more sense.

@jumde I deleted existing tests because this PR deleted all related codes and went back to chromium's original state. If we want to control exposed plugin/mimetype list strictly, I think we need to re-implement instead of previous BravePluginRegistryImpl way. (See #2128 (comment)). WDYT?

bsclifton · 2019-04-25T21:24:45Z

Did some quick tests - looks great! 😄 Will create a test plan and update original post here

Besides creating a security review (which I can help with, when ready) one of the big TODO's (several called out on brave/brave-browser#3846) would be removing the existing PDF.js install for users (in favor of PDFium)

bsclifton · 2019-04-25T21:55:34Z

Verifications:

Printing from Google web apps (Docs, Sheets, etc) saves to PDF instead of opening print dialog brave-browser#3694 still happens ☹️
Dynamically generated PDF does not load properly brave-browser#884 fixed!
PDF inside of a popup window does not load (works fine in Chrome) brave-browser#3119 fixed 🎉
PDF gets downloaded instead of opening brave-browser#1264 was fixed BEFORE this pr (on Nightly)... however this PR causes it to regress 🙀 (download is shown instead of directly loading it). ~~Might have the same root cause as~~ ~~Printing from Google web apps (Docs, Sheets, etc) saves to PDF instead of opening print dialog brave-browser#3694~~

simonhong · 2019-04-25T22:45:50Z

Pushed commit for fixing brave/brave-browser#3694. forgot to add. :)

simonhong · 2019-04-25T23:00:13Z

Hmm, brave/brave-browser#1264 is still reproduced and I checked that our current stable(0.63.48) have same issue.

bsclifton · 2019-04-25T23:01:43Z

@simonhong weird- it works for me on Nightly. But perhaps that hints to why. Does brave/brave-browser#1264 still happen with your latest fix?

simonhong · 2019-04-25T23:02:42Z

@simonhong weird- it works for me on Nightly. But perhaps that hints to why. Does brave/brave-browser#1264 still happen with your latest fix?

Yes, still happening.

simonhong · 2019-04-25T23:05:11Z

@bsclifton I'm testing on Mac and Nightly and Stable on my local have same issue... strange..

simonhong · 2019-04-25T23:11:42Z

@bsclifton http://www.fina.org/content/swimming-world-ranking seems shields issue. When shields off, it displays well. Third party cookie block causes this issue.

simonhong · 2019-04-25T23:42:56Z

Did some quick tests - looks great! 😄 Will create a test plan and update original post here

Besides creating a security review (which I can help with, when ready) one of the big TODO's (several called out on brave/brave-browser#3846) would be removing the existing PDF.js install for users (in favor of PDFium)

Yes, you're right. This PR should include logic for deleting PDF.js. I'll take a look that, too now.

browser/net/brave_common_static_redirect_network_delegate_helper.cc

bsclifton · 2019-04-27T00:16:52Z

Note to self: will look into the removal of PDF.js (and making sure it can be installed)

bsclifton

Created a test plan a while back - added some more and ran through it. Things look great!

Waiting until go-update change is deployed and security review happens before approving

diracdeltas · 2019-05-24T20:43:10Z

please remember to update
https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) since it mentions we use pdfjs

jumde · 2019-05-30T17:55:01Z

Update to https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode will be needed post merge for plugins and mime types.

https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove) - Need to be updated to remove any references to PDF.js

Fixes brave/brave-browser#3846 Fixes brave/brave-browser#3694 Fixes brave/brave-browser#884 Fixes brave/brave-browser#3119

So far, brave only exposes flash when it is available. Brave will use pdfium as a pdf viewer instead of pdf.js. That causes plugins and mimeTypes will include pdf things. That means we expose all that brave have. So, we don't need to blacklist except flash plugins.

Some google sites check pdf plugin name and do a different behavior whether browser has chrome pdf plugin or not. Ex, google docs print menu displays print preview when chrome pdf plugin is available. Otherwise, just tries to download that documents as a pdf document.

bsclifton

Tested out, works great 😄 Filled in test plan and re-tested / tagged all bugs this closes

bsclifton · 2019-05-31T07:39:56Z

go-update change pushed to prod with https://github.com/brave/devops/issues/1103

Updating the docs now...

bsclifton · 2019-05-31T07:44:04Z

Updated https://github.com/brave/brave-browser/wiki/Deviations-from-Chromium-(features-we-disable-or-remove)

@jumde I didn't see what to edit on https://github.com/brave/brave-browser/wiki/Fingerprinting-Protection-Mode - can you help me update this?

bridiver · 2019-06-14T15:50:09Z

patches/chrome-common-chrome_content_client_constants.cc.patch

+@@ -19,9 +19,9 @@ const char ChromeContentClient::kPDFExtensionPluginName[] = "Chrome PDF Viewer";
+ const char ChromeContentClient::kPDFInternalPluginName[] = "Chrome PDF Plugin";
+ #else
+ const char ChromeContentClient::kPDFExtensionPluginName[] =


this can be done with a chromium_src override

brave/brave-browser#4944

simonhong requested review from bsclifton, bbondy, jumde and bridiver April 25, 2019 05:22

simonhong self-assigned this Apr 25, 2019

simonhong added this to the 0.66.x - Nightly milestone Apr 25, 2019

simonhong mentioned this pull request Apr 25, 2019

WIP: remove pdf.js #2128

Closed

19 tasks

simonhong commented Apr 25, 2019

View reviewed changes

DEPS Outdated Show resolved Hide resolved

jumde reviewed Apr 25, 2019

View reviewed changes

bsclifton force-pushed the use_pdfium branch from afc3eb9 to 0f05db0 Compare April 25, 2019 18:40

Brave-Matt mentioned this pull request Apr 26, 2019

Printing from Google web apps (Docs, Sheets, etc) saves to PDF instead of opening print dialog brave/brave-browser#3694

Closed

jumde mentioned this pull request Apr 26, 2019

some PDF's can't be opened and generate "Invalid or corrupted PDF file." errors brave/brave-browser#3474

Closed

This was referenced Apr 26, 2019

Dynamically generated PDF does not load properly brave/brave-browser#884

Closed

Remove PDF.js in favor of using PDFium brave/brave-browser#3846

Closed

simonhong commented Apr 26, 2019

View reviewed changes

browser/net/brave_common_static_redirect_network_delegate_helper.cc Outdated Show resolved Hide resolved

bsclifton self-assigned this Apr 27, 2019

NejcZdovc removed this from the 0.66.x - Dev milestone May 15, 2019

bsclifton force-pushed the use_pdfium branch 3 times, most recently from b7bc646 to c600e87 Compare May 22, 2019 21:59

bsclifton force-pushed the use_pdfium branch from 76cce69 to ae8c837 Compare May 24, 2019 06:14

bsclifton reviewed May 24, 2019

View reviewed changes

bsclifton mentioned this pull request May 24, 2019

URL.createObjectURL() incompatibility brave/brave-browser#4424

Closed

bsclifton force-pushed the use_pdfium branch from ae8c837 to f6df699 Compare May 24, 2019 22:52

bsclifton and others added 6 commits May 30, 2019 14:26

WIP - removal of pdf.js

2681798

Fixes brave/brave-browser#3846 Fixes brave/brave-browser#3694 Fixes brave/brave-browser#884 Fixes brave/brave-browser#3119

Delete pdf.js related tests

acd5006

Update extension-whitelist checksum

611d2f1

more rebase fallout

ab13729

jumde force-pushed the use_pdfium branch from bbfebfa to ab13729 Compare May 30, 2019 21:51

bsclifton approved these changes May 31, 2019

View reviewed changes

jumde self-requested a review May 31, 2019 05:04

jumde approved these changes May 31, 2019

View reviewed changes

bsclifton modified the milestones: 0.67.x - Dev, 0.68.x - Nightly May 31, 2019

bsclifton merged commit a90dad3 into master May 31, 2019

bsclifton deleted the use_pdfium branch May 31, 2019 07:34

juliangent mentioned this pull request May 31, 2019

PDF inside of a popup window does not load (works fine in Chrome) brave/brave-browser#3119

Closed

bridiver reviewed Jun 14, 2019

View reviewed changes

simonhong mentioned this pull request Jun 16, 2019

Cleanup chrome-common-chrome_content_client_constants.cc.patch brave/brave-browser#4944

Closed

bsclifton mentioned this pull request Apr 8, 2021

PDF.js should NOT be shown in brave://extensions when launched with --show-component-extension-options brave/brave-browser#15185

Closed

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Use pdfium #2342

Use pdfium #2342

simonhong commented Apr 25, 2019 •

edited by bsclifton

Loading

jumde Apr 25, 2019

simonhong Apr 25, 2019

bsclifton commented Apr 25, 2019

bsclifton commented Apr 25, 2019 •

edited

Loading

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019

bsclifton commented Apr 25, 2019

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019 •

edited

Loading

simonhong commented Apr 25, 2019

bsclifton commented Apr 27, 2019

bsclifton left a comment

diracdeltas commented May 24, 2019

jumde commented May 30, 2019

bsclifton left a comment

bsclifton commented May 31, 2019

bsclifton commented May 31, 2019

bridiver Jun 14, 2019

simonhong Jun 16, 2019

Use pdfium #2342

Use pdfium #2342

Conversation

simonhong commented Apr 25, 2019 • edited by bsclifton Loading

Submitter Checklist:

Test Plan:

Test fix for brave/brave-browser#3694

Test fix for brave/brave-browser#884

Test fix for brave/brave-browser#4424

Embed test (possible fix for brave/brave-browser#3119)

Test that PDF.js is still installable

Test that PDF.js does not show

Reviewer Checklist:

After-merge Checklist:

jumde Apr 25, 2019

Choose a reason for hiding this comment

simonhong Apr 25, 2019

Choose a reason for hiding this comment

bsclifton commented Apr 25, 2019

bsclifton commented Apr 25, 2019 • edited Loading

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019

bsclifton commented Apr 25, 2019

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019

simonhong commented Apr 25, 2019 • edited Loading

simonhong commented Apr 25, 2019

bsclifton commented Apr 27, 2019

bsclifton left a comment

Choose a reason for hiding this comment

diracdeltas commented May 24, 2019

jumde commented May 30, 2019

bsclifton left a comment

Choose a reason for hiding this comment

bsclifton commented May 31, 2019

bsclifton commented May 31, 2019

bridiver Jun 14, 2019

Choose a reason for hiding this comment

simonhong Jun 16, 2019

Choose a reason for hiding this comment

simonhong commented Apr 25, 2019 •

edited by bsclifton

Loading

bsclifton commented Apr 25, 2019 •

edited

Loading

simonhong commented Apr 25, 2019 •

edited

Loading