Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

a-c table is not being correctly updated when excluding publishers #4561

Closed
GeetaSarvadnya opened this issue May 23, 2019 · 9 comments · Fixed by brave/brave-core#2520
Closed

Comments

@GeetaSarvadnya
Copy link
Collaborator

GeetaSarvadnya commented May 23, 2019

Description

unable to exlude site from a-c table

Steps to Reproduce

  1. Enable rewards on 0.67.14
  2. Upgrade to 0.67.55
  3. Open verified twitter pubs in new tab
  4. try to exclude the site from a-c table

Actual result:

unable to exlude site from a-c table

Twitter- unable to exclude site from a-c table

Expected result:

Should be able to exclude a site from a-c table

Reproduces how often:

Easy

Brave version (brave://version info)

Brave 0.67.55 Chromium: 75.0.3770.38 (Official Build) nightly (64-bit)
Revision 3860105745f2b12537da9e9f048f14c3f52ba970-refs/branch-heads/3770@{#618}
OS Windows 10 OS Version 1803 (Build 17134.523)

Version/Channel Information:

  • Can you reproduce this issue with the current release? No
  • Can you reproduce this issue with the beta channel? No
  • Can you reproduce this issue with the dev channel? No
  • Can you reproduce this issue with the nightly channel? Yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields? NA
  • Does the issue resolve itself when disabling Brave Rewards? NA
  • Is the issue reproducible on the latest version of Chrome? NA

Miscellaneous Information:

cc: @brave/legacy_qa @NejcZdovc

@LaurenWags
Copy link
Member

@GeetaSarvadnya does this only happen with Twitter or does it happen with other sites as well?

@srirambv
Copy link
Contributor

Reproduced on Linux nightly build 0.67.55. This is not specific to Twitter. Happens to all the sites.
Reproduced with same steps on Linux for both twitter and other pages

@srirambv
Copy link
Contributor

+1 from @jdkuki via #4601. @jdkuki mentioned a fix in the issue #4601.

@bbondy bbondy added regression priority/P2 A bad problem. We might uplift this to the next planned release. labels May 26, 2019
@bbondy
Copy link
Member

bbondy commented May 26, 2019

Please feel free to put a pretty high priority and regression label if they apply.

@GeetaSarvadnya
Copy link
Collaborator Author

@LaurenWags Issue is reproducible for other websites also.

@NejcZdovc NejcZdovc assigned jdkuki and unassigned NejcZdovc May 27, 2019
@NejcZdovc
Copy link
Contributor

So site is actually excluded/removed correctly, only UI is not updated

@NejcZdovc NejcZdovc moved this from New Issues to Backlog in Rewards May 27, 2019
@srirambv
Copy link
Contributor

@NejcZdovc yes. The UI doesn't immediately update when you delete the publisher from ac list. Its a regression

@NejcZdovc
Copy link
Contributor

@srirambv yes, @jdkuki is on it

@kjozwiak kjozwiak changed the title unable to exlude site from a-c table a-c table is not being correctly updated when excluding publishers May 28, 2019
@jdkuki
Copy link

jdkuki commented May 28, 2019

Fix in PR brave-core/pull/2520

jdkuki added a commit to brave/brave-core that referenced this issue May 30, 2019
jdkuki added a commit to brave/brave-core that referenced this issue May 30, 2019
@jdkuki jdkuki moved this from Backlog to In Progress in Rewards May 31, 2019
@jdkuki jdkuki moved this from In Progress to Review/QA in Rewards May 31, 2019
Rewards automation moved this from Review/QA to Done Jun 4, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 5, 2019
@GeetaSarvadnya
Copy link
Collaborator Author

GeetaSarvadnya commented Aug 5, 2019

Verification passed on

Brave 0.68.116 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verified passed with

Brave 0.68.119 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Mac OS X

Verification passed on

Brave 0.68.118 Chromium: 76.0.3809.87 (Official Build) beta (64-bit)
Revision 111fe1e15d5ced26080a7dc239bcfe70f6c49aad-refs/branch-heads/3809@{#967}
OS Ubuntu 18.04 LTS

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment