Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add Panel Support for GitHub #4987

Closed
jdkuki opened this issue Jun 19, 2019 · 1 comment · Fixed by brave/brave-core#2688
Closed

Add Panel Support for GitHub #4987

jdkuki opened this issue Jun 19, 2019 · 1 comment · Fixed by brave/brave-core#2688

Comments

@jdkuki
Copy link

jdkuki commented Jun 19, 2019

Description

Feature Request:
Add functionality to tip users on GitHub via panel

Steps to Reproduce

  1. Enroll in rewards
  2. Visit user profile page on GitHub
  3. Click Brave Rewards BAT Icon to open panel
  4. Text on panel should appear "(username) on GitHub"

Actual result:

N/A

Expected result:

image

Reproduces how often:

n/a

Brave version (brave://version info)

n/a

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@jdkuki jdkuki self-assigned this Jun 19, 2019
jdkuki added a commit to brave/brave-ui that referenced this issue Jun 19, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 19, 2019
jdkuki added a commit to brave/brave-ui that referenced this issue Jun 19, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 19, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 19, 2019
jdkuki added a commit to brave/brave-ui that referenced this issue Jun 19, 2019
@NejcZdovc NejcZdovc added this to New Issues in Rewards via automation Jun 20, 2019
@NejcZdovc NejcZdovc added this to the 0.68.x - Nightly milestone Jun 20, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 20, 2019
jdkuki added a commit to brave/brave-ui that referenced this issue Jun 20, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 20, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 20, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 21, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 21, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Review/QA in Rewards Jun 23, 2019
Rewards automation moved this from Review/QA to Done Jun 25, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 25, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 25, 2019
@NejcZdovc NejcZdovc reopened this Jun 25, 2019
Rewards automation moved this from Done to In Progress Jun 25, 2019
@NejcZdovc NejcZdovc moved this from In Progress to Review/QA in Rewards Jun 25, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 25, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 25, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 25, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 25, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 26, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 26, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 26, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jun 26, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Jun 27, 2019
Rewards automation moved this from Review/QA to Done Jun 27, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 5, 2019

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)
  • Verified the STR mentioned in the description

image

image

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Screen Shot 2019-09-06 at 12 46 14 PM

Screen Shot 2019-09-06 at 12 59 56 PM

Screen Shot 2019-09-06 at 12 46 33 PM

Verification passed on

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

image
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment