Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add keyboard accessibility to the New Tabs Page settings menu #5041

Closed
imptrx opened this issue Jun 25, 2019 · 2 comments · Fixed by brave/brave-core#2814
Closed

Add keyboard accessibility to the New Tabs Page settings menu #5041

imptrx opened this issue Jun 25, 2019 · 2 comments · Fixed by brave/brave-core#2814

Comments

@imptrx
Copy link

imptrx commented Jun 25, 2019

Description

If you go through the page you should be able to access the new tabs page settings via keyboard. The settings icon at the bottom left should be selectable.

Steps to Reproduce

  1. Go to new tabs page
  2. Press tab

Actual result:

The setting button will be skipped over when pressing tab but the other options will not be.
Screen Shot 2019-06-25 at 12 29 27 PM

Expected result:

  • The settings button should be selectable and should open the setting menu when space or enter is hit

Reproduces how often:

Always reproducible.

Test plan:

  • Go to new tabs page
  • Press tab
  • There should be an outline when you reach the settings icon at the bottom left of the page
  • Pressing space or enter will open the setting menu
  • Pressing tab will allow you to select the setting menu icon again
  • Pressing space or enter will open the setting menu
@imptrx imptrx self-assigned this Jun 25, 2019
@rebron rebron added this to P4 backlog in New Tab page Jun 26, 2019
@rebron rebron moved this from P4 backlog to P1, P2 backlog in New Tab page Jun 26, 2019
@rebron rebron moved this from P1, P2 backlog to In progress in New Tab page Jun 26, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jun 26, 2019
@imptrx imptrx added this to the 0.69.x - Nightly milestone Jun 26, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jun 26, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 1, 2019
@rebron rebron removed this from the 0.69.x - Nightly milestone Jul 5, 2019
@rebron rebron added the priority/P3 The next thing for us to work on. It'll ride the trains. label Jul 5, 2019
@imptrx imptrx added the blocked label Jul 8, 2019
@imptrx
Copy link
Author

imptrx commented Jul 8, 2019

Marked as blocked until: brave/brave-core#2857 is merged in.

@imptrx imptrx removed the blocked label Jul 10, 2019
imptrx added a commit to brave/brave-core that referenced this issue Jul 19, 2019
@kjozwiak kjozwiak added this to the 0.69.x - Nightly milestone Jul 22, 2019
@imptrx imptrx moved this from In progress to Completed in New Tab page Jul 22, 2019
bridiver pushed a commit to brave/brave-core that referenced this issue Jul 27, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Aug 25, 2019

Verification passed on

Brave 0.69.115 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Windows 10 OS Version 1803 (Build 17134.523)

Verification passed on

Brave 0.69.116 Chromium: 76.0.3809.100 (Official Build) beta (64-bit)
Revision ed9d447d30203dc5069e540f05079e493fc1c132-refs/branch-heads/3809@{#990}
OS Ubuntu 18.04 LTS

Verification PASSED on macOS 10.14.6 x64 using the following build:

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

@rebron rebron removed this from Completed in New Tab page Oct 1, 2019
@rebron rebron changed the title New Tabs Page settings menu needs to be keyboard accessible Add keyboard accessibility to New Tabs Page settings menu Oct 2, 2019
@rebron rebron changed the title Add keyboard accessibility to New Tabs Page settings menu Add keyboard accessibility to the New Tabs Page settings menu Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants