Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

GitHub Auto Contribution #5120

Closed
jdkuki opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/brave-core#2853
Closed

GitHub Auto Contribution #5120

jdkuki opened this issue Jul 3, 2019 · 1 comment · Fixed by brave/brave-core#2853

Comments

@jdkuki
Copy link

jdkuki commented Jul 3, 2019

Description

Feature Request:
Viewing content on a user's profile should track auto contribution for the user instead
of the tld website.

Steps to Reproduce

  1. Clean profile and join rewards
  2. Browse to a user's profile on github (https://github.com/jdkuki)
  3. Stay on their profile for at least 8 seconds
  4. Open brave://rewards
  5. (user_name) on GitHub should appear in AC table

Actual result:

n/a

Expected result:

image

Reproduces how often:

Brave version (brave://version info)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@jdkuki jdkuki added this to the 0.69.x - Nightly milestone Jul 3, 2019
@jdkuki jdkuki self-assigned this Jul 3, 2019
@jdkuki jdkuki added this to New Issues in Rewards via automation Jul 3, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 3, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 3, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 3, 2019
@NejcZdovc NejcZdovc moved this from New Issues to In Progress in Rewards Jul 4, 2019
@rebron rebron removed this from the 0.69.x - Nightly milestone Jul 5, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 12, 2019
@jdkuki jdkuki moved this from In Progress to Review/QA in Rewards Jul 18, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 23, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 23, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Jul 24, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Aug 2, 2019
jdkuki added a commit to brave/brave-core that referenced this issue Aug 7, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 18, 2019
@NejcZdovc NejcZdovc added this to the 0.72.x - Nightly milestone Sep 18, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 18, 2019
NejcZdovc pushed a commit to brave/brave-core that referenced this issue Sep 19, 2019
Rewards automation moved this from Review/QA to Done Sep 19, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 15, 2019

Verification passed on

Brave 1.1.1 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified STR from the description
    image

Verified passed with

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified STR from description (using staging)
  • Performed an auto-contribution to a verified, KYC'd github publisher (on staging). Confirmed the expected BAT was reflected in the publisher dashboard

Screen Shot 2019-11-18 at 9 41 23 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants