Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

WebTorrent: server serves files with "Content-Type: null" #5489

Closed
feross opened this issue Aug 1, 2019 · 5 comments · Fixed by brave/brave-core#3114 or brave/brave-core#3134
Closed

WebTorrent: server serves files with "Content-Type: null" #5489

feross opened this issue Aug 1, 2019 · 5 comments · Fixed by brave/brave-core#3114 or brave/brave-core#3134
Assignees
@feross
Labels
bug feature/webtorrent Label for webtorrent related issues QA/No release-notes/exclude
Milestone
0.69.x - Release

Comments

@feross
Copy link

feross commented Aug 1, 2019

If the file extension is unrecognized, the webtorrent HTTP server will use a Content-Type header with a value of null, which is invalid.
@feross feross added bug feature/webtorrent Label for webtorrent related issues labels Aug 1, 2019
@feross feross self-assigned this Aug 1, 2019
@feross feross added this to To do in WebTorrent via automation Aug 1, 2019
@feross feross moved this from To do to In progress in WebTorrent Aug 1, 2019
@feross
Copy link
Author

feross commented Aug 1, 2019

This is fixed in webtorrent@0.105.3. We need to update the version, but I'll hold off until #5490 is fixed so we can update just once.

WebTorrent automation moved this from In progress to Done Aug 1, 2019
@feross feross reopened this Aug 1, 2019
WebTorrent automation moved this from Done to In progress Aug 1, 2019
@feross
Copy link
Author

feross commented Aug 7, 2019

Once we bump the version of webtorrent, this issue will be fixed.

@feross feross mentioned this issue Aug 7, 2019
Merged
32 tasks
WebTorrent automation moved this from In progress to Done Aug 7, 2019
@yrliou yrliou added this to the 0.70.x - Nightly milestone Aug 7, 2019
This was referenced Aug 8, 2019
Merged
Merged
@yrliou yrliou modified the milestones: 0.70.x - Nightly, 0.68.x - Beta Aug 8, 2019
@yrliou
Copy link
Member

yrliou commented Aug 9, 2019

Upgrade reverted by brave/brave-core#3136

@yrliou yrliou reopened this Aug 9, 2019
WebTorrent automation moved this from Done to In progress Aug 9, 2019
@yrliou yrliou removed this from the 0.68.x - Beta milestone Aug 9, 2019
@feross feross moved this from In progress to PR sent in WebTorrent Aug 9, 2019
@feross feross mentioned this issue Aug 9, 2019
Merged
32 tasks
feross added a commit to brave/brave-core that referenced this issue Aug 9, 2019
@feross
Depend on upstream WebTorrent
d187598 
Fixes: brave/brave-browser#5587
Fixes: brave/brave-browser#856
Fixes: brave/brave-browser#5489

This makes Brave depend on upstream WebTorrent instead of the fork. This also removes the need for forks of torrent-discovery and bittorrent-tracker.
WebTorrent automation moved this from PR sent to Done Aug 9, 2019
@feross feross added this to the 0.70.x - Nightly milestone Aug 13, 2019
@btlechowski
Copy link

Could add QA/Yes or QA/No label?

@feross feross added the QA/No label Sep 20, 2019
@feross
Copy link
Author

feross commented Sep 20, 2019

Sure. I just added QA/No.

@rebron rebron removed this from Done in WebTorrent Feb 26, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@feross feross

Labels
bug feature/webtorrent Label for webtorrent related issues QA/No release-notes/exclude
Projects
None yet
Milestone
0.69.x - Release
Development

Successfully merging a pull request may close this issue.

Upgrade WebTorrent forks brave/brave-core
Depend on upstream WebTorrent brave/brave-core
4 participants
@feross @yrliou @LaurenWags @btlechowski