Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

sync bookmarks are out of order after created #5770

Closed
darkdh opened this issue Aug 22, 2019 · 4 comments · Fixed by brave/brave-core#3241
Closed

sync bookmarks are out of order after created #5770

darkdh opened this issue Aug 22, 2019 · 4 comments · Fixed by brave/brave-core#3241

Comments

@darkdh
Copy link
Member

darkdh commented Aug 22, 2019

Description

Initial sync between devices breaks bookmark order

Steps to Reproduce

  1. deviceA: A1, A2
  2. deviceB: B1, B2
  3. deviceC: no bookmarks
  4. create chain on deviceA
  5. connect deviceB to chain
  6. connect deviceC to chain

Actual result:

image

Expected result:

Three devices should have A1, A2, B1, B2

Reproduces how often:

100%

Brave version (brave://version info)

0.71.28 (Nightly)

Version/Channel Information:

  • Can you reproduce this issue with the current release?
  • Can you reproduce this issue with the beta channel?
  • Can you reproduce this issue with the dev channel?
  • Can you reproduce this issue with the nightly channel?

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

@darkdh
Copy link
Member Author

darkdh commented Aug 22, 2019

We can also test extra steps after original STR passed

  1. Add a folder "F" on device B
  2. Move A1, A2 into "F"
  3. After a while, all devices should have

Screen Shot 2019-08-22 at 15 01 06

@bsclifton
Copy link
Member

Updated milestone to 0.69.x after uplift was done 😄

@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 3, 2019

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.523)

image

image

Verification passed on

Brave 0.69.121 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Ubuntu 18.04 LTS

image

image

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified the STR from the description

Screen Shot 2019-09-30 at 5 34 31 PM

Screen Shot 2019-09-30 at 5 41 30 PM

Screen Shot 2019-09-30 at 5 41 45 PM

@Riggie1000
Copy link

Riggie1000 commented Sep 3, 2019

Found an issue.

Creating bookmarks per button works with sync by waiting about a minute. But I wanna have the same bookmark twice in another directory. So I moved the cursor to the first bookmark, copied it per rightclick and pasted it into the other directory. Now sync doesn't work.

Brave ist auf dem neuesten Stand
Version 0.68.132 Chromium: 76.0.3809.132 (Offizieller Build) (64-Bit)

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment