Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

user wallets - NY loop #5799

Closed
LaurenWags opened this issue Aug 26, 2019 · 3 comments · Fixed by brave/brave-core#3282
Closed

user wallets - NY loop #5799

LaurenWags opened this issue Aug 26, 2019 · 3 comments · Fixed by brave/brave-core#3282

Comments

@LaurenWags
Copy link
Member

Description

Reported by Uphold:

Users from NY enter a loop when they authorize Brave Browser.

Steps to Reproduce

Actual result:

jJQmP088sV

Expected result:

No loop. There should be some kind of error/information for NY users.

Reproduces how often:

unsure

Brave version (brave://version info)

0.71.35 (Nightly)

Version/Channel Information:

  • Can you reproduce this issue with the current release? no, user wallets not on release 0.68.x
  • Can you reproduce this issue with the beta channel? unsure but probably
  • Can you reproduce this issue with the dev channel? unsure but probably
  • Can you reproduce this issue with the nightly channel? yes

Other Additional Information:

  • Does the issue resolve itself when disabling Brave Shields?
  • Does the issue resolve itself when disabling Brave Rewards?
  • Is the issue reproducible on the latest version of Chrome?

Miscellaneous Information:

cc @mandar-brave

@LaurenWags LaurenWags added this to New Issues in Rewards via automation Aug 26, 2019
@mandar-brave mandar-brave added the priority/P1 A very extremely bad problem. We might push a hotfix for it. label Aug 26, 2019
@mandar-brave mandar-brave moved this from New Issues to Backlog in Rewards Aug 26, 2019
@mandar-brave
Copy link

mandar-brave commented Aug 27, 2019

When we know that a BAT card cannot be created, this text needs to be displayed to the user and allow them to close out the error dialog vs. looping.

BAT is not currently supported in your region. Please refer here for updates.
Action: Close

Referral URL: TBD

When user goes back to the Brave Rewards page, wallet shows unverified user that needs to operate using Browser Wallet state.

@NejcZdovc

@rebron rebron added this to the 0.69.x - Beta milestone Aug 27, 2019
@NejcZdovc NejcZdovc moved this from Backlog to Review/QA in Rewards Aug 28, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 28, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 28, 2019
@mandar-brave
Copy link

Replace Title" your request...." to "Error creating Brave Browser BAT card"
refer URL: https://uphold.com/en/brave/support

NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 30, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 30, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 2, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 2, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 2, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 3, 2019
Rewards automation moved this from Review/QA to Done Sep 3, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 3, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 3, 2019
@NejcZdovc NejcZdovc moved this from Done to Waiting uplift in Rewards Sep 3, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 4, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Sep 4, 2019
@NejcZdovc NejcZdovc moved this from Waiting uplift to Done in Rewards Sep 4, 2019
@LaurenWags
Copy link
Member Author

LaurenWags commented Sep 5, 2019

Verified passed with

Brave 0.69.124 Chromium: 76.0.3809.132 (Official Build) (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Mac OS X

Verification passed on

Brave 0.69.129 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Windows 10 OS Version 1803 (Build 17134.1006)

image

  • Verified that BAT can still be used in the anon state (verified I could tip a KYC'd publisher after trying to sign up with a NY account).
    NY account

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS

image

  • Verified that BAT can still be used in the anon state (verified I could tip a KYC'd publisher after trying to sign up with a NY account).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

7 participants