Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Replace 5% settlement card with an anon address #5808

Closed
mandar-brave opened this issue Aug 26, 2019 · 2 comments · Fixed by brave/brave-core#3267
Closed

Replace 5% settlement card with an anon address #5808

mandar-brave opened this issue Aug 26, 2019 · 2 comments · Fixed by brave/brave-core#3267

Comments

@mandar-brave
Copy link

Transactions sent to the non-anon card are displaying the sender.
Replace these:
const char kFeeAddressStaging[] = "7ab330ae-b7a6-4845-8f07-baab68848e4e";
const char kFeeAddressProduction[] = "532857d5-ff8b-4ca7-b9ef-5b1e40178340";

@NejcZdovc

@mandar-brave mandar-brave added feature/rewards priority/P1 A very extremely bad problem. We might push a hotfix for it. labels Aug 26, 2019
@mandar-brave mandar-brave added this to New Issues in Rewards via automation Aug 26, 2019
@mandar-brave mandar-brave moved this from New Issues to Backlog in Rewards Aug 26, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 27, 2019
NejcZdovc added a commit to brave/brave-core that referenced this issue Aug 27, 2019
@NejcZdovc NejcZdovc self-assigned this Aug 27, 2019
@NejcZdovc NejcZdovc added this to the 0.71.x - Nightly milestone Aug 27, 2019
Rewards automation moved this from Backlog to Done Aug 27, 2019
@NejcZdovc NejcZdovc moved this from Done to Waiting uplift in Rewards Aug 27, 2019
@NejcZdovc NejcZdovc moved this from Waiting uplift to Done in Rewards Aug 28, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Sep 17, 2019

Verification passed on

Brave 0.70.93 Chromium: 76.0.3809.132 (Official Build) beta (64-bit)
Revision fd1acc410994a7a68ac25bc77513d443f3130860-refs/branch-heads/3809@{#1035}
OS Windows 10 OS Version 1803 (Build 17134.1006)

(Verified in fully KYC'd staging uphold account)

  • Verified the test plan from Updates 5% cards with anon addresses brave-core#3267
  • 5% card balance before sending One time tip to a verified pub from fully KYC'd uphold account
    image
  • 5% card balance after sending a one-time tip to verified pubs from fully KYC'd uphold account and the transaction history doesn't show pubs name in the transaction which is expected as per the test plan
    image

image

@LaurenWags
Copy link
Member

LaurenWags commented Oct 1, 2019

Verified passed with

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS macOS Version 10.13.6 (Build 17G5019)
  • Requested team member with access to 5% prod card to review our tips and confirm that the 5% fee was anonymized as expected.
  • Confirmed on staging 5% card that the 5% fee was anonymized as expected. Verified test plan from Updates 5% cards with anon addresses brave-core#3267

Verification passed on

Brave 0.69.130 Chromium: 77.0.3865.90 (Official Build) (64-bit)
Revision 58c425ba843df2918d9d4b409331972646c393dd-refs/branch-heads/3865@{#830}
OS Ubuntu 18.04 LTS
  • Requested team member with access to 5% prod card to review our tips and confirm that the 5% fee was anonymized as expected.
  • Confirmed on staging 5% card that the 5% fee was anonymized as expected. Verified test plan from Updates 5% cards with anon addresses brave-core#3267

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging a pull request may close this issue.

6 participants