Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add new Monthly Contribution banner for publishers #5996

Closed
ryanml opened this issue Sep 12, 2019 · 1 comment · Fixed by brave/brave-core#3429 or brave/brave-core#4183
Closed

Add new Monthly Contribution banner for publishers #5996

ryanml opened this issue Sep 12, 2019 · 1 comment · Fixed by brave/brave-core#3429 or brave/brave-core#4183

Comments

@ryanml
Copy link
Contributor

ryanml commented Sep 12, 2019

Design:
Screen Shot 2019-09-11 at 6 55 52 PM

Prompt within the panel:
Screen Shot 2019-09-11 at 6 56 59 PM

Test Plan:

  1. Enable Brave Rewards, Deposit BAT
  2. Navigate to a verified publisher, hit the rewards icon
  3. Click the Send a Tip button
  4. Confirm that the regular tip banner shows up as expected, with no option to check monthly.
  5. Complete the tip and confirm that it processes via the tip table
  6. Navigate to the above publisher (or another verified publisher)
  7. Click the Send button in the Monthly Contribution row
  8. Confirm the new monthly tip banner variant appears
  9. Complete the contribution and verify that it shows up as a monthly contribution
  10. Navigate back to the last publisher, hit the rewards icon
  11. Confirm that you can change the monthly contribution amount via the panel
@ryanml ryanml added this to the 0.72.x - Nightly milestone Sep 12, 2019
@ryanml ryanml self-assigned this Sep 12, 2019
@ryanml ryanml added this to New Issues in Rewards via automation Sep 12, 2019
@NejcZdovc NejcZdovc moved this from New Issues to Backlog in Rewards Sep 12, 2019
@ryanml ryanml moved this from Backlog to In Progress in Rewards Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 13, 2019
@ryanml ryanml moved this from In Progress to Review/QA in Rewards Sep 13, 2019
@ryanml ryanml modified the milestones: 0.71.x - Dev, 0.72.x - Nightly Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 13, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 18, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 18, 2019
@NejcZdovc NejcZdovc moved this from Review/QA to In Progress in Rewards Sep 18, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 18, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 18, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 18, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 20, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 24, 2019
@ryanml ryanml moved this from In Progress to Review/QA in Rewards Sep 24, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 25, 2019
ryanml added a commit to brave/brave-core that referenced this issue Sep 26, 2019
Rewards automation moved this from Review/QA to Done Sep 26, 2019
@GeetaSarvadnya
Copy link

GeetaSarvadnya commented Nov 19, 2019

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Windows 10 OS Version 1803 (Build 17134.1006)
  • Verified the test plan mentioned in the issue.

Verification passed on

Brave 1.1.4 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS Ubuntu 18.04 LTS
  • Verified the test plan from the description
    image
    image
    image
    image
    image

Verified passed with

Brave 1.1.5 Chromium: 78.0.3904.97 (Official Build) beta (64-bit)
Revision 021b9028c246d820be17a10e5b393ee90f41375e-refs/branch-heads/3904@{#859}
OS macOS Version 10.13.6 (Build 17G5019)
  • Verified test plan from description
  • Confirmed if you change Monthly Contribution value on panel that change is reflected in Monthly Contribution panel on brave://rewards
  • Confirmed setting Monthly Contribution in panel to 0.0 BAT removed the monthly tip
  • Confirmed still able to remove monthly tip by clicking on the trash can icon on the Monthly Contribution panel in brave://rewards
  • Confirmed custom tip banner works with Monthly Contribution banner.

Screen Shot 2019-11-20 at 11 40 48 AM

Screen Shot 2019-11-20 at 11 41 01 AM

Screen Shot 2019-11-20 at 11 41 18 AM

Screen Shot 2019-11-20 at 11 41 29 AM

Screen Shot 2019-11-20 at 11 41 48 AM

Screen Shot 2019-11-20 at 11 44 15 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment